[coreboot-gerrit] Patch merged into coreboot/master: drivers/pc80: Rework normal / fallback selector code

gerrit at coreboot.org gerrit at coreboot.org
Tue Nov 3 21:55:22 CET 2015


the following patch was just integrated into master:
commit 3bfd7cc61e73439a2b1ac2d85faa7aaa988969ed
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Sun Nov 1 02:13:17 2015 -0600

    drivers/pc80: Rework normal / fallback selector code
    
    Per IRC and Gerrit discussion, the normal / fallback
    selector code is a rather weak spot in coreboot, and
    did not function correctly for certain use cases.
    
    Rework the selector to more clearly indicate proper
    operation, and also remove dead code.  Also tentatively
    abandon use of RTC bit 385; a follow-up patch will
    remove said bit from all affected mainboards.
    
    The correct operation of the fallback code selector
    approximates that of a power line recloser, with
    a user option to attempt normal boot that can be
    cleared by firmware, but never set by firmware.
    Additionally, if cleared by user, the fallback
    path should always be used on the next reboot.
    
    Change-Id: I753ae9f0710c524875a85354ac2547df0c305569
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
    Reviewed-on: http://review.coreboot.org/12289
    Reviewed-by: Nico Huber <nico.h at gmx.de>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/12289 for details.

-gerrit



More information about the coreboot-gerrit mailing list