[coreboot-gerrit] New patch to review for coreboot: bff2760 SLIC: Check SLIC signature.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun May 31 12:35:55 CEST 2015


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10383

-gerrit

commit bff2760da19b6df3c4bdff583d1bd9ecf45c5501
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun May 31 11:32:09 2015 +0200

    SLIC: Check SLIC signature.
    
    Change-Id: I79fd4d17b534274b1e84bc97ca5a2a6ee55e3114
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/arch/x86/boot/acpi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/boot/acpi.c b/src/arch/x86/boot/acpi.c
index a7a638f..4ce5ed6 100644
--- a/src/arch/x86/boot/acpi.c
+++ b/src/arch/x86/boot/acpi.c
@@ -762,8 +762,10 @@ unsigned long write_acpi_tables(unsigned long start)
 	slic_file = cbfs_get_file_content(CBFS_DEFAULT_MEDIA,
 				     CONFIG_CBFS_PREFIX "/slic",
 				     CBFS_TYPE_RAW, &slic_size);
-	if (slic_file && (slic_file->length > slic_size
-			  || slic_file->length < sizeof (acpi_header_t))) {
+	if (slic_file
+	    && (slic_file->length > slic_size
+		|| slic_file->length < sizeof (acpi_header_t)
+		|| memcmp(slic_file->signature, "SLIC", 4) != 0)) {
 		slic_file = 0;
 	}
 



More information about the coreboot-gerrit mailing list