[coreboot-gerrit] Patch set updated for coreboot: 7b5305a x230: Clean up smihandler.c

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Fri May 29 07:46:27 CEST 2015


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10349

-gerrit

commit 7b5305ad1fc58a4b164bb986f0fe8a0a39685e13
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Thu May 28 11:25:50 2015 +0200

    x230: Clean up smihandler.c
    
    Remove dead code and dead includes.
    
    Change-Id: I5564ebfbbef6f65c275c2f94f75724f4e36472db
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/mainboard/lenovo/x230/smihandler.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/src/mainboard/lenovo/x230/smihandler.c b/src/mainboard/lenovo/x230/smihandler.c
index 7e518ab..f0ef637 100644
--- a/src/mainboard/lenovo/x230/smihandler.c
+++ b/src/mainboard/lenovo/x230/smihandler.c
@@ -23,14 +23,8 @@
 #include <console/console.h>
 #include <cpu/x86/smm.h>
 #include <ec/acpi/ec.h>
-#include <pc80/mc146818rtc.h>
 #include <ec/lenovo/h8/h8.h>
-#include <delay.h>
-#include <southbridge/intel/bd82x6x/nvs.h>
 #include <southbridge/intel/bd82x6x/pch.h>
-#include <southbridge/intel/bd82x6x/me.h>
-#include <northbridge/intel/sandybridge/sandybridge.h>
-#include <cpu/intel/model_206ax/model_206ax.h>
 
 #define GPE_EC_SCI	1
 #define GPE_EC_WAKE	13
@@ -51,14 +45,7 @@ int mainboard_io_trap_handler(int smif)
 		smm_initialized = 1;
 	}
 
-	switch (smif) {
-	default:
-		return 0;
-	}
-
-	/* On success, the IO Trap Handler returns 1
-	 * On failure, the IO Trap Handler returns a value != 1 */
-	return 1;
+	return 0;
 }
 
 static void mainboard_smi_handle_ec_sci(void)



More information about the coreboot-gerrit mailing list