[coreboot-gerrit] Patch set updated for coreboot: 1ff4c2f cbmem: remove cbmem_set_top()

[Aaron Durbin (adurbin@chromium.org)]

Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10314

-gerrit

commit 1ff4c2fa2e61011321489d178ffa6400eaa7c1f6
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue May 26 11:26:34 2015 -0500

    cbmem: remove cbmem_set_top()
    
    Now that the users of cbmem_set_top() always provide a consistent
    cbmem_top() value there's no need to have cbmem_set_top() around.
    Therefore, delete it.
    
    Change-Id: I0c96e2b8b829eddbeb1fdf755ed59c51ea689d1b
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/arch/x86/boot/cbmem.c |  1 -
 src/include/cbmem.h       |  3 ---
 src/lib/imd_cbmem.c       | 14 --------------
 3 files changed, 18 deletions(-)

diff --git a/src/arch/x86/boot/cbmem.c b/src/arch/x86/boot/cbmem.c
index ad8aacb..a9127d7 100644
--- a/src/arch/x86/boot/cbmem.c
+++ b/src/arch/x86/boot/cbmem.c
@@ -40,7 +40,6 @@ void set_top_of_ram(uint64_t ramtop)
 {
 	backup_top_of_ram(ramtop);
 	ramtop_pointer = (void *)(uintptr_t)ramtop;
-	cbmem_set_top(ramtop_pointer);
 }
 
 static inline void *saved_ramtop(void)
diff --git a/src/include/cbmem.h b/src/include/cbmem.h
index 0a7ca89..a8ab3cd 100644
--- a/src/include/cbmem.h
+++ b/src/include/cbmem.h
@@ -176,9 +176,6 @@ void cbmem_initialize_empty_id_size(u32 id, u64 size);
  * below 4GiB. */
 void *cbmem_top(void);
 
-/* Set the top address for dynamic cbmem. Not for new designs. */
-void cbmem_set_top(void *ramtop);
-
 /* Add a cbmem entry of a given size and id. These return NULL on failure. The
  * add function performs a find first and do not check against the original
  * size. */
diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c
index 6255b18..d1ff57d 100644
--- a/src/lib/imd_cbmem.c
+++ b/src/lib/imd_cbmem.c
@@ -40,20 +40,6 @@ static inline struct imd *cbmem_get_imd(void)
 	return NULL;
 }
 
-/*
- * x86 !CONFIG_EARLY_CBMEM_INIT platforms need to do the following in ramstage:
- * 1. Call set_top_of_ram() which in turn calls cbmem_set_top().
- * 2. Provide a get_top_of_ram() implementation.
- *
- * CONFIG_EARLY_CBMEM_INIT platforms just need to provide cbmem_top().
- */
-void cbmem_set_top(void *ramtop)
-{
-	struct imd *imd = cbmem_get_imd();
-
-	imd_handle_init(imd, ramtop);
-}
-
 static inline const struct cbmem_entry *imd_to_cbmem(const struct imd_entry *e)
 {
 	return (const struct cbmem_entry *)e;