[coreboot-gerrit] Patch set updated for coreboot: 9ceba81 gm45: Link cstates.c rather than including it.
Vladimir Serbinenko (phcoder@gmail.com)
gerrit at coreboot.org
Tue May 26 09:10:21 CEST 2015
Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7375
-gerrit
commit 9ceba8124d1181fd82d0d2c5048a0a213efda905
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date: Sun Nov 9 13:44:36 2014 +0100
gm45: Link cstates.c rather than including it.
The comment about necessity of include isn't true anymore as get_cst_entries
is not weak anymore so if it's not found, the linking would fail.
Change-Id: I4bf88208d63ac3e625f464c3907e2e1ea575dd9f
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
src/mainboard/lenovo/x200/Makefile.inc | 1 +
src/mainboard/lenovo/x200/mainboard.c | 3 ---
src/mainboard/roda/rk9/Makefile.inc | 2 ++
src/mainboard/roda/rk9/mainboard.c | 3 ---
4 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/mainboard/lenovo/x200/Makefile.inc b/src/mainboard/lenovo/x200/Makefile.inc
index 85bb37a..b2e5c2a 100644
--- a/src/mainboard/lenovo/x200/Makefile.inc
+++ b/src/mainboard/lenovo/x200/Makefile.inc
@@ -18,3 +18,4 @@
##
ramstage-y += dock.c
+ramstage-y += cstates.c
diff --git a/src/mainboard/lenovo/x200/mainboard.c b/src/mainboard/lenovo/x200/mainboard.c
index f23d8d5..518b51a 100644
--- a/src/mainboard/lenovo/x200/mainboard.c
+++ b/src/mainboard/lenovo/x200/mainboard.c
@@ -32,9 +32,6 @@
#include <ec/lenovo/h8/h8.h>
#include "drivers/lenovo/lenovo.h"
-#include "cstates.c" /* Include it, as the linker won't find
- the overloaded weak function in there. */
-
static void fill_ssdt(void)
{
drivers_lenovo_serial_ports_ssdt_generate("\\_SB.PCI0.LPCB", 0);
diff --git a/src/mainboard/roda/rk9/Makefile.inc b/src/mainboard/roda/rk9/Makefile.inc
index 21bedea..d6838b7 100644
--- a/src/mainboard/roda/rk9/Makefile.inc
+++ b/src/mainboard/roda/rk9/Makefile.inc
@@ -18,3 +18,5 @@
##
ramstage-$(CONFIG_CARDBUS_PLUGIN_SUPPORT) += ti_pci7xx1.c
+ramstage-y += cstates.c
+
diff --git a/src/mainboard/roda/rk9/mainboard.c b/src/mainboard/roda/rk9/mainboard.c
index 9d31dc3..d0d9b55 100644
--- a/src/mainboard/roda/rk9/mainboard.c
+++ b/src/mainboard/roda/rk9/mainboard.c
@@ -26,9 +26,6 @@
#include <pc80/keyboard.h>
#include <ec/acpi/ec.h>
-#include "cstates.c" /* Include it, as the linker won't find
- the overloaded weak function in there. */
-
static void ec_setup(void)
{
/* Thermal limits? Values are from ectool's ram dump. */
More information about the coreboot-gerrit
mailing list