[coreboot-gerrit] New patch to review for coreboot: 1ab4044 ec/lenovo/h8: silence sound on boot

Alexander Couzens (lynxis@fe80.eu) gerrit at coreboot.org
Tue May 26 00:18:59 CEST 2015


Alexander Couzens (lynxis at fe80.eu) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10297

-gerrit

commit 1ab40441e4330ae11fb9539a4bf02565e1d544bb
Author: Alexander Couzens <lynxis at fe80.eu>
Date:   Sun May 24 03:17:42 2015 +0200

    ec/lenovo/h8: silence sound on boot
    
    Fix a bug when a sound was generated while going into suspend.
    E.g. When a low battery sound is played while going into suspend
    a sample is stuck in this register. The user will hear a sample forever.
    
    Change-Id: I103a5f462c8044ef5875a9adf812234b5e6960ac
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 src/ec/lenovo/h8/h8.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 70424a1..539adad 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -226,6 +226,9 @@ static void h8_enable(struct device *dev)
 
 	ec_write(H8_SOUND_REPEAT, 0x00);
 
+	/* silence sounds in queue */
+	ec_write(H8_SOUND_REG, 0x00);
+
 	ec_write(0x10, conf->event0_enable);
 	ec_write(0x11, conf->event1_enable);
 	ec_write(0x12, conf->event2_enable);



More information about the coreboot-gerrit mailing list