[coreboot-gerrit] New patch to review for coreboot: dcfef89 Remove unused functions

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu May 21 07:35:48 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10266

-gerrit

commit dcfef89df37f5b78ed14e38826a39b69ee64f2ed
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Thu May 21 07:34:53 2015 +0200

    Remove unused functions
    
    acpi_fill_slit and acpi_fill_srat were removed in commit 5e597572e.
    Take care of the boards that were added in the mean time.
    
    Change-Id: I907e51de5d4ce9acfcce82e6bb30eefff312d35d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/mainboard/google/rambi/acpi_tables.c        | 12 ------------
 src/mainboard/intel/bayleybay_fsp/acpi_tables.c | 12 ------------
 src/mainboard/intel/minnowmax/acpi_tables.c     | 12 ------------
 src/mainboard/lenovo/t420s/acpi_tables.c        | 12 ------------
 src/mainboard/lenovo/t430s/acpi_tables.c        | 12 ------------
 src/mainboard/siemens/mc_tcu3/acpi_tables.c     | 12 ------------
 6 files changed, 72 deletions(-)

diff --git a/src/mainboard/google/rambi/acpi_tables.c b/src/mainboard/google/rambi/acpi_tables.c
index 981116b..bf2f370 100644
--- a/src/mainboard/google/rambi/acpi_tables.c
+++ b/src/mainboard/google/rambi/acpi_tables.c
@@ -76,18 +76,6 @@ unsigned long acpi_fill_ssdt_generator(unsigned long current,
 	return (unsigned long) (acpigen_get_current());
 }
 
-unsigned long acpi_fill_slit(unsigned long current)
-{
-	// Not implemented
-	return current;
-}
-
-unsigned long acpi_fill_srat(unsigned long current)
-{
-	/* No NUMA, no SRAT */
-	return current;
-}
-
 #define ALIGN_CURRENT current = (ALIGN(current, 16))
 unsigned long write_acpi_tables(unsigned long start)
 {
diff --git a/src/mainboard/intel/bayleybay_fsp/acpi_tables.c b/src/mainboard/intel/bayleybay_fsp/acpi_tables.c
index 5f81e26..fd14700 100644
--- a/src/mainboard/intel/bayleybay_fsp/acpi_tables.c
+++ b/src/mainboard/intel/bayleybay_fsp/acpi_tables.c
@@ -78,18 +78,6 @@ unsigned long acpi_fill_ssdt_generator(unsigned long current,
 	return (unsigned long) (acpigen_get_current());
 }
 
-unsigned long acpi_fill_slit(unsigned long current)
-{
-	// Not implemented
-	return current;
-}
-
-unsigned long acpi_fill_srat(unsigned long current)
-{
-	/* No NUMA, no SRAT */
-	return current;
-}
-
 #define ALIGN_CURRENT current = (ALIGN(current, 16))
 unsigned long write_acpi_tables(unsigned long start)
 {
diff --git a/src/mainboard/intel/minnowmax/acpi_tables.c b/src/mainboard/intel/minnowmax/acpi_tables.c
index 881c143..aa07246 100644
--- a/src/mainboard/intel/minnowmax/acpi_tables.c
+++ b/src/mainboard/intel/minnowmax/acpi_tables.c
@@ -69,18 +69,6 @@ unsigned long acpi_fill_ssdt_generator(unsigned long current,
 	return (unsigned long) (acpigen_get_current());
 }
 
-unsigned long acpi_fill_slit(unsigned long current)
-{
-	// Not implemented
-	return current;
-}
-
-unsigned long acpi_fill_srat(unsigned long current)
-{
-	/* No NUMA, no SRAT */
-	return current;
-}
-
 #define ALIGN_CURRENT current = (ALIGN(current, 16))
 unsigned long write_acpi_tables(unsigned long start)
 {
diff --git a/src/mainboard/lenovo/t420s/acpi_tables.c b/src/mainboard/lenovo/t420s/acpi_tables.c
index 15b9d9a..b8eb335 100644
--- a/src/mainboard/lenovo/t420s/acpi_tables.c
+++ b/src/mainboard/lenovo/t420s/acpi_tables.c
@@ -64,15 +64,3 @@ void acpi_create_gnvs(global_nvs_t *gnvs)
 
 	acpi_update_thermal_table(gnvs);
 }
-
-unsigned long acpi_fill_slit(unsigned long current)
-{
-	// Not implemented
-	return current;
-}
-
-unsigned long acpi_fill_srat(unsigned long current)
-{
-	/* No NUMA, no SRAT */
-	return current;
-}
diff --git a/src/mainboard/lenovo/t430s/acpi_tables.c b/src/mainboard/lenovo/t430s/acpi_tables.c
index 407c8f9..1e692cd 100644
--- a/src/mainboard/lenovo/t430s/acpi_tables.c
+++ b/src/mainboard/lenovo/t430s/acpi_tables.c
@@ -50,15 +50,3 @@ void acpi_create_gnvs(global_nvs_t *gnvs)
 
 	acpi_update_thermal_table(gnvs);
 }
-
-unsigned long acpi_fill_slit(unsigned long current)
-{
-	// Not implemented
-	return current;
-}
-
-unsigned long acpi_fill_srat(unsigned long current)
-{
-	/* No NUMA, no SRAT */
-	return current;
-}
diff --git a/src/mainboard/siemens/mc_tcu3/acpi_tables.c b/src/mainboard/siemens/mc_tcu3/acpi_tables.c
index 5f81e26..fd14700 100644
--- a/src/mainboard/siemens/mc_tcu3/acpi_tables.c
+++ b/src/mainboard/siemens/mc_tcu3/acpi_tables.c
@@ -78,18 +78,6 @@ unsigned long acpi_fill_ssdt_generator(unsigned long current,
 	return (unsigned long) (acpigen_get_current());
 }
 
-unsigned long acpi_fill_slit(unsigned long current)
-{
-	// Not implemented
-	return current;
-}
-
-unsigned long acpi_fill_srat(unsigned long current)
-{
-	/* No NUMA, no SRAT */
-	return current;
-}
-
 #define ALIGN_CURRENT current = (ALIGN(current, 16))
 unsigned long write_acpi_tables(unsigned long start)
 {



More information about the coreboot-gerrit mailing list