[coreboot-gerrit] New patch to review for coreboot: ba09df4 Remove Kconfig variable that has no effect

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue May 19 21:27:51 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10253

-gerrit

commit ba09df40abdaaa6c097941d440319255d146669d
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Tue May 19 21:24:15 2015 +0200

    Remove Kconfig variable that has no effect
    
    CPU_HAS_BOOTBLOCK_INIT is only declared once and selected elsewhere
    (with no overlap), and never read. Remove it.
    
    Change-Id: I3f294b0724a87876a7e2f274e6933fe10321a69d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/arch/riscv/Kconfig             | 4 ----
 src/cpu/allwinner/a10/Kconfig      | 1 -
 src/cpu/ti/am335x/Kconfig          | 1 -
 src/soc/broadcom/cygnus/Kconfig    | 1 -
 src/soc/marvell/bg4cd/Kconfig      | 1 -
 src/soc/rockchip/rk3288/Kconfig    | 1 -
 src/soc/samsung/exynos5250/Kconfig | 1 -
 src/soc/samsung/exynos5420/Kconfig | 1 -
 8 files changed, 11 deletions(-)

diff --git a/src/arch/riscv/Kconfig b/src/arch/riscv/Kconfig
index 5d7b5c2..f87d8d2 100644
--- a/src/arch/riscv/Kconfig
+++ b/src/arch/riscv/Kconfig
@@ -25,10 +25,6 @@ config RISCV_BOOTBLOCK_CUSTOM
 	bool
 	default n
 
-config CPU_HAS_BOOTBLOCK_INIT
-	bool
-	default n
-
 config MAINBOARD_HAS_BOOTBLOCK_INIT
 	bool
 	default n
diff --git a/src/cpu/allwinner/a10/Kconfig b/src/cpu/allwinner/a10/Kconfig
index e481af0..ce68476 100644
--- a/src/cpu/allwinner/a10/Kconfig
+++ b/src/cpu/allwinner/a10/Kconfig
@@ -13,7 +13,6 @@ config CPU_SPECIFIC_OPTIONS
 	select HAVE_MONOTONIC_TIMER
 	select HAVE_UART_SPECIAL
 	select BOOTBLOCK_CONSOLE
-	select CPU_HAS_BOOTBLOCK_INIT
 
 ## TODO Change this to some better address not overlapping bootblock when
 ## cbfstool supports creating header in arbitrary location.
diff --git a/src/cpu/ti/am335x/Kconfig b/src/cpu/ti/am335x/Kconfig
index 0150e16..8d3c691 100644
--- a/src/cpu/ti/am335x/Kconfig
+++ b/src/cpu/ti/am335x/Kconfig
@@ -6,7 +6,6 @@ config CPU_TI_AM335X
 	select HAVE_MONOTONIC_TIMER
 	select HAVE_UART_SPECIAL
 	select BOOTBLOCK_CONSOLE
-	select CPU_HAS_BOOTBLOCK_INIT
 	select GENERIC_UDELAY
 	bool
 	default n
diff --git a/src/soc/broadcom/cygnus/Kconfig b/src/soc/broadcom/cygnus/Kconfig
index b2f0613..1c0eb0e 100644
--- a/src/soc/broadcom/cygnus/Kconfig
+++ b/src/soc/broadcom/cygnus/Kconfig
@@ -25,7 +25,6 @@ config SOC_BROADCOM_CYGNUS
 	select ARCH_ROMSTAGE_ARMV7
 	select ARCH_VERSTAGE_ARMV7
 	select BOOTBLOCK_CONSOLE
-	select CPU_HAS_BOOTBLOCK_INIT
 	select DYNAMIC_CBMEM
 	select EARLY_CONSOLE
 	select GENERIC_UDELAY
diff --git a/src/soc/marvell/bg4cd/Kconfig b/src/soc/marvell/bg4cd/Kconfig
index 9c0dc14..18dda55 100644
--- a/src/soc/marvell/bg4cd/Kconfig
+++ b/src/soc/marvell/bg4cd/Kconfig
@@ -26,7 +26,6 @@ config SOC_MARVELL_BG4CD
 	select ARCH_VERSTAGE_ARMV7_M
 	select ARM_BOOTBLOCK_CUSTOM if VBOOT_VERIFY_FIRMWARE
 	select BOOTBLOCK_CONSOLE
-	select CPU_HAS_BOOTBLOCK_INIT
 	select DYNAMIC_CBMEM
 	select EARLY_CONSOLE
 	select GENERIC_UDELAY
diff --git a/src/soc/rockchip/rk3288/Kconfig b/src/soc/rockchip/rk3288/Kconfig
index 4cdbeea..f659c8f 100644
--- a/src/soc/rockchip/rk3288/Kconfig
+++ b/src/soc/rockchip/rk3288/Kconfig
@@ -24,7 +24,6 @@ config SOC_ROCKCHIP_RK3288
 	select ARCH_VERSTAGE_ARMV7
 	select ARCH_ROMSTAGE_ARMV7
 	select ARCH_RAMSTAGE_ARMV7
-	select CPU_HAS_BOOTBLOCK_INIT
 	select HAVE_MONOTONIC_TIMER
 	select GENERIC_UDELAY
 	select HAVE_UART_MEMORY_MAPPED
diff --git a/src/soc/samsung/exynos5250/Kconfig b/src/soc/samsung/exynos5250/Kconfig
index ea63e9c..2008650 100644
--- a/src/soc/samsung/exynos5250/Kconfig
+++ b/src/soc/samsung/exynos5250/Kconfig
@@ -3,7 +3,6 @@ config CPU_SAMSUNG_EXYNOS5250
 	select ARCH_VERSTAGE_ARMV7
 	select ARCH_ROMSTAGE_ARMV7
 	select ARCH_RAMSTAGE_ARMV7
-	select CPU_HAS_BOOTBLOCK_INIT
 	select HAVE_MONOTONIC_TIMER
 	select GENERIC_UDELAY
 	select HAVE_UART_SPECIAL
diff --git a/src/soc/samsung/exynos5420/Kconfig b/src/soc/samsung/exynos5420/Kconfig
index 56ffed1..02c71c0 100644
--- a/src/soc/samsung/exynos5420/Kconfig
+++ b/src/soc/samsung/exynos5420/Kconfig
@@ -3,7 +3,6 @@ config CPU_SAMSUNG_EXYNOS5420
 	select ARCH_VERSTAGE_ARMV7
 	select ARCH_ROMSTAGE_ARMV7
 	select ARCH_RAMSTAGE_ARMV7
-	select CPU_HAS_BOOTBLOCK_INIT
 	select HAVE_MONOTONIC_TIMER
 	select GENERIC_UDELAY
 	select HAVE_UART_SPECIAL



More information about the coreboot-gerrit mailing list