[coreboot-gerrit] New patch to review for coreboot: 2d95d04 gma/edid: Fix gma register access.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Mon May 18 13:17:57 CEST 2015


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10237

-gerrit

commit 2d95d04614ff19960398c41ad5d90366d2a8bc6c
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Mon May 18 13:13:48 2015 +0200

    gma/edid: Fix gma register access.
    
    0x20 was incorrectly represented as 4 * 5 while in fact it's 4 * 8
    
    Change-Id: I6053a3baa6de0da9f1d648009353bc1fe542f81f
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/drivers/intel/gma/edid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c
index 36d8813..e70156e 100644
--- a/src/drivers/intel/gma/edid.c
+++ b/src/drivers/intel/gma/edid.c
@@ -49,11 +49,11 @@ void intel_gmbus_read_edid(u8 *mmio, u8 bus, u8 slave, u8 *edid, u32 edid_size)
 	write32(mmio + 4 * 0, bus);
 	wait_rdy(mmio);
 	/* Ensure index bits are disabled.  */
-	write32(mmio + 4 * 5, 0);
+	write32(mmio + 4 * 8, 0);
 	write32(mmio + 4 * 1, 0x46000000 | (slave << 1));
 	wait_rdy(mmio);
 	/* Ensure index bits are disabled.  */
-	write32(mmio + 4 * 5, 0);
+	write32(mmio + 4 * 8, 0);
 	write32(mmio + 4 * 1, 0x4a000001 | (slave << 1)
 		| (edid_size << 16));
 	for (i = 0; i < edid_size / 4; i++) {



More information about the coreboot-gerrit mailing list