[coreboot-gerrit] Patch set updated for coreboot: a8a3c34 x230/smihandler: Kill non-functional brightness code.
Vladimir Serbinenko (phcoder@gmail.com)
gerrit at coreboot.org
Sun May 17 15:58:19 CEST 2015
Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10218
-gerrit
commit a8a3c34c8feea71a34a838efb276c29785113ef8
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date: Fri May 15 17:33:50 2015 +0200
x230/smihandler: Kill non-functional brightness code.
Just a copypaste, never worked.
Change-Id: I84b46a5a0ada2e472894c63a17170e0979ad9160
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
src/mainboard/lenovo/x230/smihandler.c | 30 ------------------------------
1 file changed, 30 deletions(-)
diff --git a/src/mainboard/lenovo/x230/smihandler.c b/src/mainboard/lenovo/x230/smihandler.c
index 8208fe7..3fbcce7 100644
--- a/src/mainboard/lenovo/x230/smihandler.c
+++ b/src/mainboard/lenovo/x230/smihandler.c
@@ -67,23 +67,6 @@ int mainboard_io_trap_handler(int smif)
return 1;
}
-static void mainboard_smi_brightness_up(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
-}
-
-static void mainboard_smi_brightness_down(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
- (value - 0x10) & 0xf0);
-}
-
static void mainboard_smi_handle_ec_sci(void)
{
u8 status = inb(EC_SC);
@@ -94,19 +77,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event);
-
- switch (event) {
- case 0x14:
- /* brightness up */
- mainboard_smi_brightness_up();
- break;
- case 0x15:
- /* brightness down */
- mainboard_smi_brightness_down();
- break;
- default:
- break;
- }
}
void mainboard_smi_gpi(u32 gpi_sts)
More information about the coreboot-gerrit
mailing list