[coreboot-gerrit] New patch to review for coreboot: 3aca557 chromeos: add missing vboot functions

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Fri May 8 23:08:09 CEST 2015


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10151

-gerrit

commit 3aca557cb59241f962ccb3b3d52e419568b353be
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri May 8 15:54:31 2015 -0500

    chromeos: add missing vboot functions
    
    Somewhere along the development path the following
    vboot functions were dropped:
      int vboot_enable_developer(void)
      int vboot_enable_recovery(void)
    
    Add them back, but also refactor the flag extraction
    so as not duplicate all that same logic.
    
    Change-Id: Id58f3b99f29caeff98b2d3111cfa28241d15b54f
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/vendorcode/google/chromeos/chromeos.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/vendorcode/google/chromeos/chromeos.c b/src/vendorcode/google/chromeos/chromeos.c
index fb72673..1e49bd1 100644
--- a/src/vendorcode/google/chromeos/chromeos.c
+++ b/src/vendorcode/google/chromeos/chromeos.c
@@ -26,7 +26,7 @@
 #include <console/console.h>
 #include "vboot_handoff.h"
 
-int vboot_skip_display_init(void)
+static int vboot_handoff_flag(uint32_t flag)
 {
 	struct vboot_handoff *vbho;
 
@@ -35,7 +35,22 @@ int vboot_skip_display_init(void)
 	if (vbho == NULL)
 		return 0;
 
-	return !(vbho->init_params.out_flags & VB_INIT_OUT_ENABLE_DISPLAY);
+	return !!(vbho->init_params.out_flags & flag);
+}
+
+int vboot_skip_display_init(void)
+{
+	return !vboot_handoff_flag(VB_INIT_OUT_ENABLE_DISPLAY);
+}
+
+int vboot_enable_developer(void)
+{
+	return vboot_handoff_flag(VB_INIT_OUT_ENABLE_DEVELOPER);
+}
+
+int vboot_enable_recovery(void)
+{
+	return vboot_handoff_flag(VB_INIT_OUT_ENABLE_RECOVERY);
 }
 
 int __attribute__((weak)) clear_recovery_mode_switch(void)



More information about the coreboot-gerrit mailing list