[coreboot-gerrit] Patch merged into coreboot/master: 3e060ed cbfstool: Fix leak in cbfs_image struct initialization
gerrit at coreboot.org
gerrit at coreboot.org
Fri May 8 20:23:25 CEST 2015
the following patch was just integrated into master:
commit 3e060ed112c5ec3a5fa58b68174dd57708af1d89
Author: Sol Boucher <solb at chromium.org>
Date: Tue May 5 15:40:15 2015 -0700
cbfstool: Fix leak in cbfs_image struct initialization
This patches a memory leak on every struct cbfs_image creation that
was introduced by c1d1fd850ee7b8e52bd2ea5064fab68ac0c27098. Since that
commit, the CBFS master header has been copied to a separate buffer so
that its endianness could be fixed all at once; unfortunately, this
buffer was malloc()'d but never free()'d. To address the issue, we
replace the structure's struct cbfs_header * with a struct cbfs_header
to eliminate the additional allocation.
Change-Id: Ie066c6d4b80ad452b366a2a95092ed45aa55d91f
Signed-off-by: Sol Boucher <solb at chromium.org>
Reviewed-on: http://review.coreboot.org/10130
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/10130 for details.
-gerrit
More information about the coreboot-gerrit
mailing list