[coreboot-gerrit] New patch to review for coreboot: 639e25f drivers/spi/stmicro: Fixes for N25Q256

David Imhoff (dimhoff_devel@xs4all.nl) gerrit at coreboot.org
Sun May 3 16:16:11 CEST 2015


David Imhoff (dimhoff_devel at xs4all.nl) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10077

-gerrit

commit 639e25f853f55ae9728f7075e5b3d437b16cf720
Author: David Imhoff <dimhoff_devel at xs4all.nl>
Date:   Sun May 3 16:05:41 2015 +0200

    drivers/spi/stmicro: Fixes for N25Q256
    
    '.op_erase' was not specified for this chip, added it. Removed the 'A'
    at the end of the product name. This only indicates the production
    process(64 nm), and is also left out for the other chips. Finally
    corrected page/sector sizes to be able to use the 'sub sector erase'
    command.
    
    Untested, due to lack of hardware.
    
    Change-Id: Icc2748fbd3afeb56693e1c17d97eb490fba67064
    Signed-off-by: David Imhoff <dimhoff_devel at xs4all.nl>
---
 src/drivers/spi/stmicro.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/drivers/spi/stmicro.c b/src/drivers/spi/stmicro.c
index b67c072..37907f6 100644
--- a/src/drivers/spi/stmicro.c
+++ b/src/drivers/spi/stmicro.c
@@ -57,7 +57,7 @@
 #define STM_ID_M25P64		0x2017
 #define STM_ID_M25P80		0x2014
 #define STM_ID_M25P128		0x2018
-#define STM_ID_N25Q256A		0xba19
+#define STM_ID_N25Q256		0xba19
 #define STM_ID_N25Q064		0xbb17
 #define STM_ID_N25Q128		0xbb18
 
@@ -164,11 +164,12 @@ static const struct stmicro_spi_flash_params stmicro_spi_flash_table[] = {
 		.name = "N25Q128",
 	},
 	{
-		.device_id = STM_ID_N25Q256A,
+		.device_id = STM_ID_N25Q256,
+		.op_erase = CMD_M25PXX_SSE,
 		.page_size = 256,
-		.pages_per_sector = 256,
-		.nr_sectors = 512,
-		.name = "N25Q256A",
+		.pages_per_sector = 16,
+		.nr_sectors = 8192,
+		.name = "N25Q256",
 	},
 };
 



More information about the coreboot-gerrit mailing list