[coreboot-gerrit] New patch to review for coreboot: 819172a Kconfig: Move `CBFS_SIZE` to section Mainboard

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat May 2 08:29:17 CEST 2015


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10061

-gerrit

commit 819172a1f92f29cee81f5a4d5defb0f84d6d5af2
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat May 2 08:22:09 2015 +0200

    Kconfig: Move `CBFS_SIZE` to section Mainboard
    
    Commit f780c40f (CBFS: Correct ROM_SIZE for ARM boards, use CBFS_SIZE
    for cbfstool) [1] adds a description to the Kconfig variable
    `CBFS_SIZE`, which makes it visible in the Kconfig menu (`make
    menuconfig`).
    
    	(0x400000) Size of CBFS filesystem in ROM
    
    To not clutter the main menu, move that option to the section
    *Mainboard* as discussed on the mailing list [1].
    
    [1] http://coreboot.org/pipermail/coreboot/2015-May/079784.html
        [coreboot] Kconfig: Move `CBFS_SIZE` out of main section
    
    Change-Id: I16b13e4861cbbf4a8f780d7df7b61ba7d0721c5b
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/Kconfig           | 10 ----------
 src/mainboard/Kconfig | 10 ++++++++++
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index df4e320..77984d5 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -465,16 +465,6 @@ config IOAPIC
 	bool
 	default n
 
-config CBFS_SIZE
-	hex "Size of CBFS filesystem in ROM"
-	default ROM_SIZE
-	help
-	  This is the part of the ROM actually managed by CBFS, located at the
-	  end of the ROM (passed through cbfstool -o) on x86 and at at the start
-	  of the ROM (passed through cbfstool -s) everywhere else. Defaults to
-	  span the whole ROM but can be overwritten to make coreboot live
-	  alongside other components (like ChromeOS's vboot/FMAP).
-
 config CACHE_ROM_SIZE_OVERRIDE
 	hex
 	default 0
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig
index d7cdc3d..af17bf9 100644
--- a/src/mainboard/Kconfig
+++ b/src/mainboard/Kconfig
@@ -130,6 +130,16 @@ config ROM_SIZE
 	default 0xc00000 if COREBOOT_ROMSIZE_KB_12288
 	default 0x1000000 if COREBOOT_ROMSIZE_KB_16384
 
+config CBFS_SIZE
+	hex "Size of CBFS filesystem in ROM"
+	default ROM_SIZE
+	help
+	  This is the part of the ROM actually managed by CBFS, located at the
+	  end of the ROM (passed through cbfstool -o) on x86 and at at the start
+	  of the ROM (passed through cbfstool -s) everywhere else. Defaults to
+	  span the whole ROM but can be overwritten to make coreboot live
+	  alongside other components (like ChromeOS's vboot/FMAP).
+
 config ENABLE_POWER_BUTTON
 	bool "Enable the power button" if POWER_BUTTON_IS_OPTIONAL
 	default y if POWER_BUTTON_DEFAULT_ENABLE



More information about the coreboot-gerrit mailing list