[coreboot-gerrit] New patch to review for coreboot: 8dde8aa mips: don't open code romstage loading

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue Mar 31 02:48:52 CEST 2015


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9172

-gerrit

commit 8dde8aaf6146d43359f7c989dea201e48eaace46
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Mon Mar 30 19:47:02 2015 -0500

    mips: don't open code romstage loading
    
    Use the run_romstage() API to prevent code duplication
    and more maintenance for any API changes or features.
    
    Change-Id: I4122b813cccf4dc0703f256e1245deeeb90deeb9
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/arch/mips/bootblock_simple.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/arch/mips/bootblock_simple.c b/src/arch/mips/bootblock_simple.c
index 49ea24d..747a8bf 100644
--- a/src/arch/mips/bootblock_simple.c
+++ b/src/arch/mips/bootblock_simple.c
@@ -19,17 +19,12 @@
  * MA 02110-1301 USA
  */
 
-#include <arch/hlt.h>
-#include <arch/stages.h>
 #include <bootblock_common.h>
-#include <cbfs.h>
 #include <console/console.h>
+#include <program_loading.h>
 
 void main(void)
 {
-	const char *stage_name = "fallback/romstage";
-	void *entry;
-
 	bootblock_cpu_init();
 	bootblock_mainboard_init();
 
@@ -37,9 +32,5 @@ void main(void)
 	console_init();
 #endif
 
-	entry = cbfs_load_stage(CBFS_DEFAULT_MEDIA, stage_name);
-	if (entry != (void *)-1)
-		stage_exit(entry);
-
-	hlt();
+	run_romstage();
 }



More information about the coreboot-gerrit mailing list