[coreboot-gerrit] New patch to review for coreboot: b80a2cb mips: fix write_table

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Mar 30 14:41:57 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9166

-gerrit

commit b80a2cbf4a5a216c60b6654b7fa3db365491633d
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Mon Mar 30 14:06:33 2015 +0200

    mips: fix write_table
    
    This replicates commit 3f7ad7b216b4021c7cb93201a94b0fae46f5e19e and
    commit 823edda98e6512d3f455b61549efea6fa68ee2b0 for mips.
    
    Change-Id: Id97e1fefa20cfa3bcb2cf0336b5a4ff7d9fe813b
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
 src/arch/mips/tables.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/arch/mips/tables.c b/src/arch/mips/tables.c
index 858fa79..9bd72d7 100644
--- a/src/arch/mips/tables.c
+++ b/src/arch/mips/tables.c
@@ -30,11 +30,7 @@
 
 #define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
 
-void cbmem_arch_init(void)
-{
-}
-
-struct lb_memory *write_tables(void)
+void write_tables(void)
 {
 	unsigned long table_pointer, new_table_pointer;
 
@@ -44,7 +40,7 @@ struct lb_memory *write_tables(void)
 						 MAX_COREBOOT_TABLE_SIZE);
 	if (!table_pointer) {
 		printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n");
-		return NULL;
+		return;
 	}
 
 	new_table_pointer = write_coreboot_table(0UL, 0UL, table_pointer,
@@ -62,6 +58,4 @@ struct lb_memory *write_tables(void)
 
 	/* Print CBMEM sections */
 	cbmem_list();
-
-	return get_lb_mem();
 }



More information about the coreboot-gerrit mailing list