[coreboot-gerrit] New patch to review for coreboot: 18cdea2 emulation/imgvp-pistachio: Drop board

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Mar 30 14:41:56 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9164

-gerrit

commit 18cdea24fa9c4a529aaa016035319792b830c8b3
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Mon Mar 30 13:29:45 2015 +0200

    emulation/imgvp-pistachio: Drop board
    
    This doesn't even compile in downstream.
    
    Change-Id: Ic7b3736db86e8de155e0f37afa970ce5095396fa
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
 src/mainboard/emulation/Kconfig                    |  4 --
 src/mainboard/emulation/imgvp-pistachio/Kconfig    | 53 ----------------------
 .../emulation/imgvp-pistachio/Makefile.inc         | 22 ---------
 .../emulation/imgvp-pistachio/bootblock.c          | 24 ----------
 .../emulation/imgvp-pistachio/devicetree.cb        | 26 -----------
 .../emulation/imgvp-pistachio/mainboard.c          | 33 --------------
 src/mainboard/emulation/imgvp-pistachio/romstage.c | 29 ------------
 7 files changed, 191 deletions(-)

diff --git a/src/mainboard/emulation/Kconfig b/src/mainboard/emulation/Kconfig
index d2706fa..e48c242 100644
--- a/src/mainboard/emulation/Kconfig
+++ b/src/mainboard/emulation/Kconfig
@@ -14,9 +14,6 @@ config BOARD_EMULATION_QEMU_ARMV7
 config BOARD_EMULATION_QEMU_UCB_RISCV
 	bool "QEMU ucb riscv"
 
-config BOARD_EMULATION_IMGVP_PISTACHIO
-	bool "ImgTec Pistachio Virtual Platform"
-
 endchoice
 
 config BOARD_EMULATION_QEMU_X86
@@ -28,7 +25,6 @@ source "src/mainboard/emulation/qemu-i440fx/Kconfig"
 source "src/mainboard/emulation/qemu-q35/Kconfig"
 source "src/mainboard/emulation/qemu-armv7/Kconfig"
 source "src/mainboard/emulation/qemu-riscv/Kconfig"
-source "src/mainboard/emulation/imgvp-pistachio/Kconfig"
 
 config MAINBOARD_VENDOR
 	string
diff --git a/src/mainboard/emulation/imgvp-pistachio/Kconfig b/src/mainboard/emulation/imgvp-pistachio/Kconfig
deleted file mode 100644
index 068528e..0000000
--- a/src/mainboard/emulation/imgvp-pistachio/Kconfig
+++ /dev/null
@@ -1,53 +0,0 @@
-#
-# This file is part of the coreboot project.
-#
-# Copyright (C) 2014 Imagination Technologies
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; version 2 of
-# the License.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
-# MA 02110-1301 USA
-#
-
-if BOARD_EMULATION_IMGVP_PISTACHIO
-
-config BOARD_SPECIFIC_OPTIONS
-	def_bool y
-	select BOOTBLOCK_CONSOLE
-	select CPU_IMGTEC_PISTACHIO
-
-config MAINBOARD_DIR
-	string
-	default emulation/imgvp-pistachio
-
-config MAINBOARD_PART_NUMBER
-	string
-	default "ImgTec Pistachio Virtual Platform"
-
-config BOOTBLOCK_MAINBOARD_INIT
-	string
-	default "mainboard/emulation/imgvp-pistachio/bootblock.c"
-
-config SYS_SDRAM_BASE
-	hex "SDRAM base address"
-	default 0x80000000
-
-config DRAM_SIZE_MB
-	int
-	default 256
-
-config HEAP_SIZE
-	hex
-	default 0x08000000
-
-endif
diff --git a/src/mainboard/emulation/imgvp-pistachio/Makefile.inc b/src/mainboard/emulation/imgvp-pistachio/Makefile.inc
deleted file mode 100644
index 8be1b22..0000000
--- a/src/mainboard/emulation/imgvp-pistachio/Makefile.inc
+++ /dev/null
@@ -1,22 +0,0 @@
-#
-# This file is part of the coreboot project.
-#
-# Copyright 2014 Imagination Technologies Ltd.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; version 2 of
-# the License.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
-# MA 02110-1301 USA
-#
-
-romstage-y += romstage.c
diff --git a/src/mainboard/emulation/imgvp-pistachio/bootblock.c b/src/mainboard/emulation/imgvp-pistachio/bootblock.c
deleted file mode 100644
index 1784a02..0000000
--- a/src/mainboard/emulation/imgvp-pistachio/bootblock.c
+++ /dev/null
@@ -1,24 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2014 Imagination Technologies
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-void bootblock_mainboard_init(void)
-{
-}
diff --git a/src/mainboard/emulation/imgvp-pistachio/devicetree.cb b/src/mainboard/emulation/imgvp-pistachio/devicetree.cb
deleted file mode 100644
index a328b9d..0000000
--- a/src/mainboard/emulation/imgvp-pistachio/devicetree.cb
+++ /dev/null
@@ -1,26 +0,0 @@
-#
-# This file is part of the coreboot project.
-#
-# Copyright (C) 2014 Imagination Technologies
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; version 2 of
-# the License.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
-# MA 02110-1301 USA
-#
-
-chip soc/imgtec/pistachio
-	chip drivers/generic/generic # I2C0 controller
-		device i2c 6 on end # Fake component for testing
-	end
-end
diff --git a/src/mainboard/emulation/imgvp-pistachio/mainboard.c b/src/mainboard/emulation/imgvp-pistachio/mainboard.c
deleted file mode 100644
index fdae940..0000000
--- a/src/mainboard/emulation/imgvp-pistachio/mainboard.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2014 Imagination Technologies
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-#include <console/console.h>
-#include <device/device.h>
-
-static void mainboard_enable(device_t dev)
-{
-	printk(BIOS_INFO, "Enable imgvp-pistachio device...\n");
-}
-
-struct chip_operations mainboard_ops = {
-	.enable_dev = mainboard_enable,
-};
-
diff --git a/src/mainboard/emulation/imgvp-pistachio/romstage.c b/src/mainboard/emulation/imgvp-pistachio/romstage.c
deleted file mode 100644
index 3fcf23d..0000000
--- a/src/mainboard/emulation/imgvp-pistachio/romstage.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2014 Imagination Technologies
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-#include <program_loading.h>
-#include <console/console.h>
-
-void main(void)
-{
-	console_init();
-	run_ramstage();
-}



More information about the coreboot-gerrit mailing list