[coreboot-gerrit] Patch set updated for coreboot: c35ec4e rush: ryu: remove mainboard_add_memory_ranges()

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Sat Mar 28 07:26:54 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9101

-gerrit

commit c35ec4e5d18e316a4af5978ca9a9793dee971f2f
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Sep 24 09:11:16 2014 -0500

    rush: ryu: remove mainboard_add_memory_ranges()
    
    There's no need to add DMA ranges for these boards as
    that memory is allocated within dpethcharge now. Additionally,
    the DRAM_DMA_* Kconfig options were removed resulting in 0
    values.
    
    BUG=None
    TEST=Built rush and ryu.
    BRANCH=None
    
    Change-Id: I597437960e4fddbf6d26f0b15ddeefc4557adc8b
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: f26b503d759b2bac902e58e928d7c625c1a6c575
    Original-Change-Id: I52bb8f760a56226c75611f7981570a44d56f242e
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/219710
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
 src/mainboard/google/rush/mainboard.c     | 8 --------
 src/mainboard/google/rush_ryu/mainboard.c | 7 -------
 2 files changed, 15 deletions(-)

diff --git a/src/mainboard/google/rush/mainboard.c b/src/mainboard/google/rush/mainboard.c
index ccac5e4..846a7ac 100644
--- a/src/mainboard/google/rush/mainboard.c
+++ b/src/mainboard/google/rush/mainboard.c
@@ -106,11 +106,3 @@ struct chip_operations mainboard_ops = {
         .name   = "rush",
         .enable_dev = mainboard_enable,
 };
-
-
-void mainboard_add_memory_ranges(struct memranges *map)
-{
-	/* Create non-cacheable region for DMA operations. */
-	memranges_insert(map, CONFIG_DRAM_DMA_START, CONFIG_DRAM_DMA_SIZE,
-			 MA_MEM  | MA_MEM_NC | MA_NS | MA_RW);
-}
diff --git a/src/mainboard/google/rush_ryu/mainboard.c b/src/mainboard/google/rush_ryu/mainboard.c
index ffa3234..e19ad02 100644
--- a/src/mainboard/google/rush_ryu/mainboard.c
+++ b/src/mainboard/google/rush_ryu/mainboard.c
@@ -78,10 +78,3 @@ struct chip_operations mainboard_ops = {
 	.name   = "rush_ryu",
 	.enable_dev = mainboard_enable,
 };
-
-void mainboard_add_memory_ranges(struct memranges *map)
-{
-	/* Create non-cacheable region for DMA operations. */
-	memranges_insert(map, CONFIG_DRAM_DMA_START, CONFIG_DRAM_DMA_SIZE,
-			MA_MEM  | MA_MEM_NC | MA_NS | MA_RW);
-}



More information about the coreboot-gerrit mailing list