[coreboot-gerrit] New patch to review for coreboot: 8d7e5b9 armv8/secmon: SECMON_SRC is really SECMON_BIN

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Mar 27 16:04:49 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9113

-gerrit

commit 8d7e5b92ecedf0087bd7017dbe9338cf3794da1b
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Fri Mar 27 14:24:11 2015 +0100

    armv8/secmon: SECMON_SRC is really SECMON_BIN
    
    It points to a binary.
    
    This is inspired by the commit listed below, but rewritten to match
    upstream, and split in smaller pieces to keep intent clear.
    
    Change-Id: I164d7f717a9523d187e2c215083e176b59fd5acc
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Based-On-Change-Id: I50af7dacf616e0f8ff4c43f4acc679089ad7022b
    Based-On-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Based-On-Reviewed-on: https://chromium-review.googlesource.com/219170
---
 src/arch/arm64/armv8/secmon/Makefile.inc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/arch/arm64/armv8/secmon/Makefile.inc b/src/arch/arm64/armv8/secmon/Makefile.inc
index 1c7a696..a8d42b0 100644
--- a/src/arch/arm64/armv8/secmon/Makefile.inc
+++ b/src/arch/arm64/armv8/secmon/Makefile.inc
@@ -22,7 +22,7 @@
 $(eval $(call create_class_compiler,secmon,arm64))
 
 SECMON_DIR=$(obj)/arch/arm64/armv8/secmon
-SECMON_SRC=$(SECMON_DIR)/secmon
+SECMON_BIN=$(SECMON_DIR)/secmon
 SECMON_OBJ=$(SECMON_DIR)/secmon.o
 SECMON_ELF=$(SECMON_DIR)/secmon.elf
 SECMON_RMOD=$(SECMON_DIR)/secmon.elf.rmod
@@ -39,16 +39,16 @@ secmon-y += ../exception.c
 secmon-y += ../../cpu.c
 secmon-y += ../../transition_asm.S ../../transition.c
 
-ramstage-srcs += $(SECMON_SRC)
+ramstage-srcs += $(SECMON_BIN)
 
 $(SECMON_OBJ):  $$(secmon-objs)
 		$(CC_secmon) $(LDFLAGS) -nostdlib -r -o $@ $^
 
 $(eval $(call rmodule_link,$(SECMON_ELF), $(SECMON_OBJ), 0,arm64))
 
-$(SECMON_SRC): $(SECMON_RMOD)
+$(SECMON_BIN): $(SECMON_RMOD)
 	       $(OBJCOPY_secmon) -O binary $< $@
 
-$(SECMON_RAMSTAGE): $(SECMON_SRC)
+$(SECMON_RAMSTAGE): $(SECMON_BIN)
 		    @printf "    OBJCOPY $(subst $(obj)/,,$(@))\n"
 		    cd $(dir $@); $(OBJCOPY_secmon) -I binary $(notdir $<) -O elf64-littleaarch64 -B aarch64 $(notdir $@)



More information about the coreboot-gerrit mailing list