[coreboot-gerrit] Patch merged into coreboot/master: 8ff6c21 arm64: remove printk() before console_init()

gerrit at coreboot.org gerrit at coreboot.org
Fri Mar 27 08:05:13 CET 2015


the following patch was just integrated into master:
commit 8ff6c215a1c759ed4506a0bdbe4aa6a2fe9bd74f
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Sat Sep 6 01:07:41 2014 -0500

    arm64: remove printk() before console_init()
    
    printk() shouldn't be called until the consoles have been
    initialized. This just so happened to work by luck. Once
    CONFIG_SMP is enabled that breaks because of spinlock
    usage in uncached memory.
    
    BUG=chrome-os-partner:31761
    BRANCH=None
    TEST=Built with CONFIG_SMP and ramstage doesn't hang early.
    
    Change-Id: I54231db3c811c0d19c5c7fbaa406cacd1ff019ec
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 31c3f972ac5c89472009b5b2cb7dbc0f02cfd9a0
    Original-Change-Id: I6091b1e949e648b3435231946e5924260bf1807f
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/216920
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
    Reviewed-on: http://review.coreboot.org/9037
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9037 for details.

-gerrit



More information about the coreboot-gerrit mailing list