[coreboot-gerrit] Patch merged into coreboot/master: 047f03a broadwell: Fix TCO register size and event reporting

gerrit at coreboot.org gerrit at coreboot.org
Fri Mar 27 05:40:43 CET 2015


the following patch was just integrated into master:
commit 047f03ab548ba298c01cbdb1fc64cbde8e1122ce
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Aug 11 09:54:19 2014 -0700

    broadwell: Fix TCO register size and event reporting
    
    TCO registers are 16bit not 32bit.  Also do not log the
    TCO reset event in S3 resume path to avoid it being logged
    when TCO is not actually tripping.
    
    BUG=chrome-os-partner:28234
    BRANCH=None
    TEST=manual:
    1) build and boot on samus
    2) modify kernel command line with nmi_watchdog=0
    3) while sleep 1 ; do echo -n V ; done > /dev/watchdog &
    4) fg 1
    5) ctrl-Z
    6) wait for reboot
    7) check event log for TCO event
    8) check suspend/resume path to ensure no TCO event logged
    
    Original-Change-Id: I9cd8627de8498b280deb088f3a8e1e20546e2f96
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/211840
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit 5952fe4672d07bd39e345f2048c2bfc510bf9f2a)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I6cdeffb8b50c5001d714edd3a1264cf117cd1ad6
    Reviewed-on: http://review.coreboot.org/8954
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at google.com>


See http://review.coreboot.org/8954 for details.

-gerrit



More information about the coreboot-gerrit mailing list