[coreboot-gerrit] Patch set updated for coreboot: 9a0ea1a soc: Use DEVICE_NOOP macro formalism over static stub func

Edward O'Callaghan (edward.ocallaghan@koparo.com) gerrit at coreboot.org
Fri Mar 27 03:54:00 CET 2015


Edward O'Callaghan (edward.ocallaghan at koparo.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8989

-gerrit

commit 9a0ea1ad79374696ed8e04616fc8ec0c610816ab
Author: Edward O'Callaghan <edward.ocallaghan at koparo.com>
Date:   Thu Mar 26 20:10:09 2015 +1100

    soc: Use DEVICE_NOOP macro formalism over static stub func
    
    Change-Id: Ice7e27230010ffc48948f952394e849533f94085
    Signed-off-by: Edward O'Callaghan <edward.ocallaghan at koparo.com>
---
 src/soc/nvidia/tegra132/soc.c |  8 ++------
 src/soc/rockchip/rk3288/soc.c | 16 +++-------------
 2 files changed, 5 insertions(+), 19 deletions(-)

diff --git a/src/soc/nvidia/tegra132/soc.c b/src/soc/nvidia/tegra132/soc.c
index 519ba37..bf2c5db 100644
--- a/src/soc/nvidia/tegra132/soc.c
+++ b/src/soc/nvidia/tegra132/soc.c
@@ -65,14 +65,10 @@ static void soc_init(device_t dev)
 	clock_init_arm_generic_timer();
 }
 
-static void soc_noop(device_t dev)
-{
-}
-
 static struct device_operations soc_ops = {
 	.read_resources   = soc_read_resources,
-	.set_resources    = soc_noop,
-	.enable_resources = soc_noop,
+	.set_resources    = DEVICE_NOOP,
+	.enable_resources = DEVICE_NOOP,
 	.init             = soc_init,
 	.scan_bus         = 0,
 };
diff --git a/src/soc/rockchip/rk3288/soc.c b/src/soc/rockchip/rk3288/soc.c
index 0985c08..52dabe7 100644
--- a/src/soc/rockchip/rk3288/soc.c
+++ b/src/soc/rockchip/rk3288/soc.c
@@ -34,21 +34,11 @@ static void soc_enable(device_t dev)
 	ram_resource(dev, 0, RAM_BASE_KB, RAM_SIZE_KB);
 }
 
-static void soc_init(device_t dev)
-{
-
-}
-
-static void soc_noop(device_t dev)
-{
-
-}
-
 static struct device_operations soc_ops = {
-	.read_resources   = soc_noop,
-	.set_resources    = soc_noop,
+	.read_resources   = DEVICE_NOOP,
+	.set_resources    = DEVICE_NOOP,
 	.enable_resources = soc_enable,
-	.init             = soc_init,
+	.init             = DEVICE_NOOP,
 	.scan_bus         = 0,
 };
 



More information about the coreboot-gerrit mailing list