[coreboot-gerrit] Patch set updated for coreboot: 42cf922 ryu: configure plld for display usage

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Mar 26 13:14:46 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9026

-gerrit

commit 42cf922bbf755c3905ad5365f5a20a34e520f401
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Aug 28 15:49:31 2014 -0500

    ryu: configure plld for display usage
    
    The kernel doesn't have the logic for bringing up the plld.
    Therefore, configure it in the firmware. The clock used
    is an interim value until the display controller sequencing
    is fully implemented.
    
    BUG=chrome-os-partner:31640
    BRANCH=None
    TEST=Noted configured freq is close to requested. Also, no
         more plld errors observed from the kernel.
    
    Change-Id: I0788c83843699ec7cef52b3a219ebb9b0db9082f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: b44956ec87e9083aebe589349cbe168f7f101d8b
    Original-Change-Id: I6f57d5c48630385d1814e7ef61898a2d49c8f747
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/214841
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
 src/mainboard/google/rush_ryu/mainboard.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/mainboard/google/rush_ryu/mainboard.c b/src/mainboard/google/rush_ryu/mainboard.c
index 3828a36..7953855 100644
--- a/src/mainboard/google/rush_ryu/mainboard.c
+++ b/src/mainboard/google/rush_ryu/mainboard.c
@@ -50,7 +50,16 @@ static const struct funit_cfg funits[] = {
 
 static void mainboard_init(device_t dev)
 {
+	/* PLLD should be 2 * pixel clock (301620khz). */
+	const uint32_t req_disp_clk =  301620 * 1000 * 2;
+	uint32_t disp_clk;
+
 	soc_configure_funits(funits, ARRAY_SIZE(funits));
+	disp_clk = clock_display(req_disp_clk);
+
+	if (disp_clk != req_disp_clk)
+		printk(BIOS_DEBUG, "display clock: %u vs %u (r)\n", disp_clk,
+			req_disp_clk);
 }
 
 static void mainboard_enable(device_t dev)



More information about the coreboot-gerrit mailing list