[coreboot-gerrit] Patch set updated for coreboot: b859d97 tegra132: enable pinmux input for PAD_CFG_GPIO_INPUT()

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Mar 25 17:26:59 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8913

-gerrit

commit b859d979cfe328bf2a9b64513fcbf3b264f4ad6d
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Aug 5 13:49:09 2014 -0500

    tegra132: enable pinmux input for PAD_CFG_GPIO_INPUT()
    
    The original intent was to set the equivalent flags by default
    for the PAD_CFG_* macros so as not to make the usage too chatty.
    The GPIO_INPUT variant didn't have the PINMUX_INPUT_ENABLE field
    set. Therefore, automaticaly set it for PAD_CFG_GPIO_INPUT().
    
    BUG=chrome-os-partner:29981
    BRANCH=None
    TEST=Built and ran on ryu.
    
    Change-Id: Iab058874314430de08010912c3fc758a98b73eb0
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 535cdb354efc067caf32d32641846f11fb0cd2ee
    Original-Change-Id: Ifb630601cf04d2984542933382aace16540863ad
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/211133
    Original-Reviewed-by: Tom Warren <twarren at nvidia.com>
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
 src/soc/nvidia/tegra132/include/soc/padconfig.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/nvidia/tegra132/include/soc/padconfig.h b/src/soc/nvidia/tegra132/include/soc/padconfig.h
index f7cf629..addec8b 100644
--- a/src/soc/nvidia/tegra132/include/soc/padconfig.h
+++ b/src/soc/nvidia/tegra132/include/soc/padconfig.h
@@ -37,7 +37,7 @@ struct pad_config {
 
 #define PAD_CFG_GPIO_INPUT(ball_, pinmux_flgs_)		\
 	{						\
-		.pinmux_flags = pinmux_flgs_,		\
+		.pinmux_flags = pinmux_flgs_ | PINMUX_INPUT_ENABLE,	\
 		.gpio_index = PAD_TO_GPIO_##ball_,	\
 		.pinmux_index = PINMUX_##ball_##_INDEX,	\
 		.sfio = 0,				\



More information about the coreboot-gerrit mailing list