[coreboot-gerrit] Patch set updated for coreboot: b82983a tegra132: fix gpio constants

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Mar 24 22:56:50 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8907

-gerrit

commit b82983a34510e70e729ba67e1d098316e03b59c2
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Mon Aug 4 15:38:42 2014 -0500

    tegra132: fix gpio constants
    
    I erroneously added GPIO_NONE_INDEX at the beginning of the
    enum block effectively putting every GPIO index off by 1.
    Instead, move it to the end.
    
    BUG=chrome-os-partner:29981
    BRANCH=None
    TEST=Built and ran through to depthcharge on rush. Also
         printed out banks, port, and bit offsets to validate.
    
    Change-Id: I4f6510c1b6fcdddddbe36ff738299b4439ffc597
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 4c020c2125b9a2378a7faa17209d1b78e019c7df
    Original-Change-Id: I0471480e8658de9e534beb859a1f5027a961d73e
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/210908
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
 src/soc/nvidia/tegra132/pinmux.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/nvidia/tegra132/pinmux.h b/src/soc/nvidia/tegra132/pinmux.h
index 4f69dce..f3bab1d 100644
--- a/src/soc/nvidia/tegra132/pinmux.h
+++ b/src/soc/nvidia/tegra132/pinmux.h
@@ -32,7 +32,6 @@
 	GPIO_##port##6_INDEX, GPIO_##port##7_INDEX
 
 enum {
-	GPIO_NONE_INDEX = 0,
 	GPIO_PORT_CONSTANTS(A),
 	GPIO_PORT_CONSTANTS(B),
 	GPIO_PORT_CONSTANTS(C),
@@ -64,7 +63,8 @@ enum {
 	GPIO_PORT_CONSTANTS(CC),
 	GPIO_PORT_CONSTANTS(DD),
 	GPIO_PORT_CONSTANTS(EE),
-	GPIO_PORT_CONSTANTS(FF)
+	GPIO_PORT_CONSTANTS(FF),
+	GPIO_NONE_INDEX = 0,
 };
 
 #define PINMUX_CONSTANTS_GPIO(name, gpio) \



More information about the coreboot-gerrit mailing list