[coreboot-gerrit] New patch to review for coreboot: 5ffe582 broadwell: fixed power gating enable for disabled sata port

[Marc Jones (marc.jones@se-eng.com)]

Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8960

-gerrit

commit 5ffe5828a0b04e43338ce4ee28d912404851b5dd
Author: Kane Chen <kane.chen at intel.com>
Date:   Thu Aug 21 10:36:17 2014 -0700

    broadwell: fixed power gating enable for disabled sata port
    
    The original code won't set power gating for disabled port correctly,
    due to it must be set before Lock
    
    BUG=chrome-os-partner:28234
    BRANCH=None
    TEST=build and boot on samus
         verify bit 24, 26 is set in RCBA(0x3a84) for samus
    
    Original-Signed-off-by: Kane Chen <kane.chen at intel.com>
    Original-Change-Id: Id78d391ac657665a972cb4fd1810df6304a5a6ab
    Original-Reviewed-on: https://chromium-review.googlesource.com/213561
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Tested-by: Kane Chen <kane.chen at intel.com>
    Original-Commit-Queue: Kane Chen <kane.chen at intel.com>
    (cherry picked from commit 066c8c81df8be9ae9ab7b33342a93b0b3ea7b240)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Ic7c87b04863f93de5665d72e0f95b4105b1d4d3b
---
 src/soc/intel/broadwell/finalize.c | 3 +++
 src/soc/intel/broadwell/lpc.c      | 2 --
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/broadwell/finalize.c b/src/soc/intel/broadwell/finalize.c
index 4f7a518..bf77a87 100644
--- a/src/soc/intel/broadwell/finalize.c
+++ b/src/soc/intel/broadwell/finalize.c
@@ -100,6 +100,9 @@ static void broadwell_finalize(void *unused)
 	reg_script_run_on_dev(SA_DEV_ROOT, system_agent_finalize_script);
 	reg_script_run_on_dev(PCH_DEV_LPC, pch_finalize_script);
 
+	/* Lock */
+	RCBA32_OR(0x3a6c, 0x00000001);
+
 	/* Read+Write the following registers */
 	MCHBAR32(0x6030) = MCHBAR32(0x6030);
 	MCHBAR32(0x6034) = MCHBAR32(0x6034);
diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c
index 0e5a260..d7a3e82 100644
--- a/src/soc/intel/broadwell/lpc.c
+++ b/src/soc/intel/broadwell/lpc.c
@@ -350,8 +350,6 @@ static void pch_pm_init(struct device *dev)
 	if (RCBA32(FD) & PCH_DISABLE_ADSPD)
 		RCBA32_OR(0x2b1c, (1 << 29));
 
-	/* Lock */
-	RCBA32_OR(0x3a6c, 0x00000001);
 }
 
 static void pch_cg_init(device_t dev)