[coreboot-gerrit] New patch to review for coreboot: d6e585a ryu: configure EC I2C pads as open drain

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8916

-gerrit

commit d6e585a105f5868d7f0406a6bdb27161a4ad709a
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Aug 5 14:05:34 2014 -0500

    ryu: configure EC I2C pads as open drain
    
    The I2C pads connected to the EC are pulled to 3.3V. Therefore
    the pads need to be configured as open drain.
    
    BUG=chrome-os-partner:29981
    BRANCH=None
    TEST=Built and booted through depthcharge on ryu
    
    Change-Id: Ie5eadfe6aca78eb31fbca4e8d8117d1061acbbec
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 1530e7e7f500be47355eada56591ac2dbf1e9326
    Original-Change-Id: Ia4ad2377d01296235fc7efbba72fa790016c04af
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/211135
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
 src/mainboard/google/rush_ryu/romstage.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/rush_ryu/romstage.c b/src/mainboard/google/rush_ryu/romstage.c
index e570c99..307c1f7 100644
--- a/src/mainboard/google/rush_ryu/romstage.c
+++ b/src/mainboard/google/rush_ryu/romstage.c
@@ -31,9 +31,9 @@ static const struct pad_config padcfgs[] = {
 	/* TPM on I2C3 */
 	PAD_CFG_SFIO(CAM_I2C_SCL, PINMUX_INPUT_ENABLE, I2C3),
 	PAD_CFG_SFIO(CAM_I2C_SDA, PINMUX_INPUT_ENABLE, I2C3),
-	/* EC on I2C2 */
-	PAD_CFG_SFIO(GEN2_I2C_SCL, PINMUX_INPUT_ENABLE, I2C2),
-	PAD_CFG_SFIO(GEN2_I2C_SDA, PINMUX_INPUT_ENABLE, I2C2),
+	/* EC on I2C2 - pulled to 3.3V  */
+	PAD_CFG_SFIO(GEN2_I2C_SCL, PINMUX_OPEN_DRAIN|PINMUX_INPUT_ENABLE, I2C2),
+	PAD_CFG_SFIO(GEN2_I2C_SDA, PINMUX_OPEN_DRAIN|PINMUX_INPUT_ENABLE, I2C2),
 	/* WP_L */
 	PAD_CFG_GPIO_INPUT(KB_ROW1, PINMUX_PULL_NONE),
 };