[coreboot-gerrit] Patch merged into coreboot/master: e73335c libpayload: usb: xhci: set ENT flag in last Normal TRB

gerrit at coreboot.org gerrit at coreboot.org
Mon Mar 23 18:41:22 CET 2015


the following patch was just integrated into master:
commit e73335ce8ec518035df525142e5e9f4b92ccd143
Author: Sourabh Banerjee <sbanerje at codeaurora.org>
Date:   Wed Sep 24 16:14:45 2014 +0530

    libpayload: usb: xhci: set ENT flag in last Normal TRB
    
    If a TD is comprised of one or more Normal TRBs and terminated with an
    Event Data TRB, then the transition to the Idle state (and associated
    Stream state save) could occur after all the data for the TD has been
    moved (e.g. after Transfer Event TRBs have been executed), but before the
    Event Data TRB is executed. Under these conditions, the execution of the
    Event Data TRB is necessary to complete the TD, otherwise it does not
    occur until the next time the Stream is scheduled. This could lead to the
    lock up.
    
    The Evaluate Next TRB(ENT) flag provides a means of forcing the execution
    of a terminating Event Data TRB. Setting ENT flag in last Normal TRB makes
    the xHC to evaluate the Even Data TRB.
    
    BUG=chrome-os-partner:29375
    TEST=Verified kernel boot-up on storm from previously failing USB stick.
         USB stick model: Sandisk Ultra USB 3.0 Pen Drive 32 GB
    		      Strontium Jet USB 3.0 Pen Drive 32 GB
    
    Change-Id: I092e2109c55c2274239c493cb67b47d730304ed2
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 7eefb3b2858c841165ae839d349d2a0be50fbcc8
    Original-Change-Id: I4e123577ec5a5996d87d2fc52cb6cf5c571c9fae
    Original-Signed-off-by: Sourabh Banerjee <sbanerje at codeaurora.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/220123
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Original-Commit-Queue: Vadim Bendebury <vbendeb at chromium.org>
    Original-Tested-by: Vadim Bendebury <vbendeb at chromium.org>
    Reviewed-on: http://review.coreboot.org/8736
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/8736 for details.

-gerrit



More information about the coreboot-gerrit mailing list