[coreboot-gerrit] Patch merged into coreboot/master: 9c9c336 Generalize revision number calculation function

gerrit at coreboot.org gerrit at coreboot.org
Mon Mar 23 17:20:12 CET 2015


the following patch was just integrated into master:
commit 9c9c3364643d9b8e138f503c391163475c9dfffc
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Wed Jul 23 09:40:02 2014 -0700

    Generalize revision number calculation function
    
    Some platforms use tertiary interpretation of GPIO input state to
    increase number of distinct values represented by a limited number of
    GPIOs. The three states are
    
    - external pull down (interpreted as 0)
    - external pull up (1)
    - not connected (2)
    
    This has been required by Nvidia devices so far, but Exynos and
    Ipq8086 platforms need this too.
    
    This patch moves the function reading the tertiary state into the
    library and exposes the necessary GPIO API functions in a new include
    file. The functions are still supposed to be provided by platform
    specific modules.
    
    The function interpreting the GPIO states has been modified to allow
    to interpret the state either as a true tertiary number or as a set
    two bit fields.
    
    Since linker garbage collection is not happening when building x86
    targets, a new configuration option is being added to include the new
    module only when needed.
    
    BUG=chrome-os-partner:30489
    TEST=verified that nyan_big still reports proper revision ID.
    
    Change-Id: Ib55122c359629b58288c1022da83e6c63dc2264d
    Original-Change-Id: I243c9f43c82bd4a41de2154bbdbd07df0a241046
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/209673
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit c79ef1c545d073eaad69e6c8c629f9656b8c2f3e)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    Reviewed-on: http://review.coreboot.org/8717
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/8717 for details.

-gerrit



More information about the coreboot-gerrit mailing list