[coreboot-gerrit] Patch set updated for coreboot: 7dc7820 Include board ID calculations only when necessary

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Mar 23 15:57:19 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8720

-gerrit

commit 7dc7820a8380026285f1818b0d09fd93b6dbb75c
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Mon Jul 28 16:08:34 2014 -0700

    Include board ID calculations only when necessary
    
    For the majority of Chrome OS boards there is no need to include board
    ID calculation in any stage but ramstage, where the ID should be
    available for inclusion into the coreboot table.
    
    BUG=chrome-os-partner:30489
    TEST=build only, no other tests yet
    
    Change-Id: I1451d52382bc48cc126d40267e0f61712f4a6d4b
    Original-Change-Id: Ib9c06698a399d31e79a9b14143343ba2ad46d0fb
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/210117
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    (cherry picked from commit 27dd40e85bfcd0a38f388bad4d79f5fbb77a7566)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
---
 src/mainboard/google/nyan/Makefile.inc       | 1 +
 src/mainboard/google/nyan_big/Makefile.inc   | 2 +-
 src/mainboard/google/nyan_blaze/Makefile.inc | 2 +-
 src/mainboard/google/rush/Makefile.inc       | 4 ++--
 src/mainboard/google/rush_ryu/Makefile.inc   | 2 +-
 5 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/google/nyan/Makefile.inc b/src/mainboard/google/nyan/Makefile.inc
index b66cd55..ace6e32 100644
--- a/src/mainboard/google/nyan/Makefile.inc
+++ b/src/mainboard/google/nyan/Makefile.inc
@@ -37,5 +37,6 @@ romstage-y += romstage.c
 romstage-y += sdram_configs.c
 romstage-$(CONFIG_CHROMEOS) += chromeos.c
 
+ramstage-y += boardid.c
 ramstage-y += mainboard.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
diff --git a/src/mainboard/google/nyan_big/Makefile.inc b/src/mainboard/google/nyan_big/Makefile.inc
index b66cd55..59a1653 100644
--- a/src/mainboard/google/nyan_big/Makefile.inc
+++ b/src/mainboard/google/nyan_big/Makefile.inc
@@ -27,7 +27,6 @@ $(obj)/generated/bct.cfg:
 
 subdirs-y += bct
 
-bootblock-y += boardid.c
 bootblock-y += bootblock.c
 bootblock-y += pmic.c
 bootblock-y += reset.c
@@ -37,5 +36,6 @@ romstage-y += romstage.c
 romstage-y += sdram_configs.c
 romstage-$(CONFIG_CHROMEOS) += chromeos.c
 
+ramstage-y += boardid.c
 ramstage-y += mainboard.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
diff --git a/src/mainboard/google/nyan_blaze/Makefile.inc b/src/mainboard/google/nyan_blaze/Makefile.inc
index dec8f64..2630dc5 100644
--- a/src/mainboard/google/nyan_blaze/Makefile.inc
+++ b/src/mainboard/google/nyan_blaze/Makefile.inc
@@ -27,7 +27,6 @@ $(obj)/generated/bct.cfg:
 
 subdirs-y += bct
 
-bootblock-y += boardid.c
 bootblock-y += bootblock.c
 bootblock-y += pmic.c
 bootblock-y += reset.c
@@ -40,5 +39,6 @@ romstage-y += romstage.c
 romstage-y += sdram_configs.c
 romstage-$(CONFIG_CHROMEOS) += chromeos.c
 
+ramstage-y += boardid.c
 ramstage-y += mainboard.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
diff --git a/src/mainboard/google/rush/Makefile.inc b/src/mainboard/google/rush/Makefile.inc
index e4520c1..ddf6660 100644
--- a/src/mainboard/google/rush/Makefile.inc
+++ b/src/mainboard/google/rush/Makefile.inc
@@ -27,7 +27,6 @@ $(obj)/generated/bct.cfg:
 
 subdirs-y += bct
 
-bootblock-y += boardid.c
 bootblock-y += bootblock.c
 bootblock-y += pmic.c
 bootblock-y += reset.c
@@ -38,6 +37,7 @@ romstage-y += sdram_configs.c
 romstage-$(CONFIG_CHROMEOS) += chromeos.c
 romstage-y += ec_dummy.c
 
+ramstage-y += boardid.c
 ramstage-y += mainboard.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
-ramstage-y += ec_dummy.c
\ No newline at end of file
+ramstage-y += ec_dummy.c
diff --git a/src/mainboard/google/rush_ryu/Makefile.inc b/src/mainboard/google/rush_ryu/Makefile.inc
index 3c2b5da..9faba25 100644
--- a/src/mainboard/google/rush_ryu/Makefile.inc
+++ b/src/mainboard/google/rush_ryu/Makefile.inc
@@ -27,7 +27,6 @@ $(obj)/generated/bct.cfg:
 
 subdirs-y += bct
 
-bootblock-y += boardid.c
 bootblock-y += bootblock.c
 bootblock-y += pmic.c
 bootblock-y += reset.c
@@ -36,4 +35,5 @@ romstage-y += reset.c
 romstage-y += romstage.c
 romstage-y += sdram_configs.c
 
+ramstage-y += boardid.c
 ramstage-y += mainboard.c



More information about the coreboot-gerrit mailing list