[coreboot-gerrit] New patch to review for coreboot: 409e191 Fix the toolchain test to at least give us a *hint*

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Fri Mar 20 19:04:18 CET 2015


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8834

-gerrit

commit 409e19174dd12880ffb46519cdb62610d67432e0
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Fri Mar 20 10:59:23 2015 -0700

    Fix the toolchain test to at least give us a *hint*
    
    The toolchain test should be a lot more verbose than it is,
    because it's fragile. If you're building ARM, it runs
    the x86 compiler and complains if its not a coreboot version.
    
    Have it at least give us a hint about what to do.
    
    Change-Id: Id30508a7e12501d6087bbe5b9af205a81bfdbd15
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
---
 Makefile.inc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index cc696e4..f8903e1 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -34,7 +34,12 @@ ifeq ($(CONFIG_COMPILER_GCC),y)
 ifneq ($(CONFIG_ANY_TOOLCHAIN),y)
 _toolchain=$(shell $(CC_x86_32) -v 2>&1 |grep -q "gcc version .*coreboot toolchain" && echo coreboot)
 ifneq ($(_toolchain),coreboot)
-$(error Please use the coreboot toolchain (or prove that your toolchain works))
+$(error  The toolchain is $(_toolchain) \
+	But we want it to be coreboot	\
+	This command failed: \
+	$(CC_x86_32) -v 2\>\&1 \|grep -q "gcc version .*coreboot toolchain"\
+Please use the coreboot toolchain (or prove that your toolchain works) \
+Or set CONFIG_ANY_TOOLCHAIN if this test is broken (which it might be))
 endif
 endif
 endif



More information about the coreboot-gerrit mailing list