[coreboot-gerrit] Patch merged into coreboot/master: 032d4d2 spi: do not use malloc in Winbond driver

gerrit at coreboot.org gerrit at coreboot.org
Fri Mar 20 16:02:16 CET 2015


the following patch was just integrated into master:
commit 032d4d258030c0b25325d2906c2a97b59f82bf40
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Nov 11 07:17:24 2014 -0800

    spi: do not use malloc in Winbond driver
    
    When the driver is included in bootblock, malloc() is not available.
    Come to think of it, it is perfectly fine to use a statically
    allocated structure for the SPI device descriptor - coreboot is
    unlikely to require concurrent support of multiple SPI devices of the
    same kind.
    
    BRANCH=none
    BUG=chrome-os-partner:31438
    TEST=bootblock on the FPGA board recognizes the installed Winbond
         device:
    
      coreboot-4.0 bootblock Tue Nov 11 07:27:24 PST 2014 starting...
      SF: Detected W25Q16 with page size 1000, total 200000
    
    Change-Id: Iea1936a219d38848580a10f75eb8bbcab17e6507
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 0b4082442aa526d387a80cb5872d78670e6b468b
    Original-Change-Id: Iaa69d610ef18e69b1ae5ade2d958f9fe1595a723
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/228959
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/8771
    Tested-by: build bot (Jenkins)
    Reviewed-by: David Hendricks <dhendrix at chromium.org>


See http://review.coreboot.org/8771 for details.

-gerrit



More information about the coreboot-gerrit mailing list