[coreboot-gerrit] New patch to review for coreboot: 692d3a7 cbfs: change 1 message level to WARNING if cbfs can't find specific data

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Mar 20 13:16:26 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8821

-gerrit

commit 692d3a70d85f0e35b87f51e1875809ce4092302e
Author: Kane Chen <kane.chen at intel.com>
Date:   Mon Sep 8 09:04:28 2014 -0700

    cbfs: change 1 message level to WARNING if cbfs can't find specific data
    
    In some cases, we need to use 1 common VGA device ID to share
    among different VGA devices.
    But it will show error when it can't find a specific pci rom
    by PCI DID.
    in fact, it will find the pci rom with common vga ID.
    Without this commit, you may need to skip error check during
    suspend_stress_test
    
    BUG=none
    BRANCH=none
    TEST=build OK, and check no error on Auron and Samus
    
    Change-Id: I2b18347e46c831038f048cfd0b065430c72c6f30
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 4c32ee21b4c942182e5ffb21b58b93fa7c082223
    Original-Change-Id: Ib743e960f772b7e2e73a1feb80790a13bd8c06c7
    Original-Signed-off-by: Kane Chen <kane.chen at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/217415
    Original-Reviewed-by: Bernie Thompson <bhthompson at chromium.org>
---
 src/lib/cbfs_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/cbfs_core.c b/src/lib/cbfs_core.c
index 6455a07..c28a865 100644
--- a/src/lib/cbfs_core.c
+++ b/src/lib/cbfs_core.c
@@ -153,7 +153,7 @@ ssize_t cbfs_locate_file(struct cbfs_media *media, struct cbfs_file *file,
 			uint32_t new_align = align;
 			if (offset % align)
 				new_align += align - (offset % align);
-			ERROR("ERROR: No file header found at 0x%x - "
+			LOG("WARNING: No file header found at 0x%x - "
 			      "try next aligned address: 0x%x.\n", offset,
 			      offset + new_align);
 			offset += new_align;



More information about the coreboot-gerrit mailing list