[coreboot-gerrit] New patch to review for coreboot: b0d87bf libpayload arm64: Remove dependency on coreboot tables for dma areas

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Mar 20 10:33:50 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8789

-gerrit

commit b0d87bf7147837c9d008229a5e605a99112f51d4
Author: Furquan Shaikh <furquan at google.com>
Date:   Thu Sep 4 15:22:53 2014 -0700

    libpayload arm64: Remove dependency on coreboot tables for dma areas
    
    Libpayload should be able to setup its own dma areas and not depend on coreboot
    tables for passing this information. This patch and next allow libpayload to
    setup dma areas while performing mmu_init
    
    BUG=chrome-os-partner:31634
    BRANCH=None
    TEST=Compiles successfully and dma areas are setup properly with the mmu init patch
    
    Change-Id: I5f6fd19a957c7626a2bbe6b826c8987e64ed248f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 4f3552b8d3439a8b12d1e0b15ef67dcb14b8c96a
    Original-Change-Id: I44d9f394fa349abd7182c4ba10f1eaefd6e4fdaa
    Original-Signed-off-by: Furquan Shaikh <furquan at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/216822
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Tested-by: Furquan Shaikh <furquan at chromium.org>
    Original-Commit-Queue: Furquan Shaikh <furquan at chromium.org>
---
 payloads/libpayload/arch/arm64/coreboot.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/payloads/libpayload/arch/arm64/coreboot.c b/payloads/libpayload/arch/arm64/coreboot.c
index 056d63e..59f84c0 100644
--- a/payloads/libpayload/arch/arm64/coreboot.c
+++ b/payloads/libpayload/arch/arm64/coreboot.c
@@ -35,27 +35,17 @@
 /* This pointer gets set in head.S and is passed in from coreboot. */
 void *cb_header_ptr;
 
-static void cb_parse_dma(void *ptr)
-{
-	struct lb_range *dma = (struct lb_range *)ptr;
-	init_dma_memory(phys_to_virt(dma->range_start), dma->range_size);
-}
+/* == Architecture specific == */
 
 int cb_parse_arch_specific(struct cb_record *rec, struct sysinfo_t *info)
 {
 	switch(rec->tag) {
-	case CB_TAG_DMA:
-		cb_parse_dma(rec);
-		break;
 	default:
 		return 0;
 	}
 	return 1;
 }
 
-/* == Architecture specific == */
-/* FIXME put in actual address range */
-
 int get_coreboot_info(struct sysinfo_t *info)
 {
 	return cb_parse_header(cb_header_ptr, 1, info);



More information about the coreboot-gerrit mailing list