[coreboot-gerrit] Patch set updated for coreboot: 7a415c9 libpayload arm64: Move console_init after post_sysinfo_mmu_setup call

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Mar 20 10:56:10 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8795

-gerrit

commit 7a415c9ab1ac3ad419cc88b7c83c0a9233e4cbd5
Author: Furquan Shaikh <furquan at google.com>
Date:   Thu Oct 9 15:59:12 2014 -0700

    libpayload arm64: Move console_init after post_sysinfo_mmu_setup call
    
    This is important since mmu is disabled during the post_sysinfo_mmu_setup call
    and calling printf can cause unaligned access.
    
    BUG=None
    BRANCH=None
    TEST=Compiles successfully and boots to kernel prompt with console_init
    
    Change-Id: I5ef72ee449fdcf30186f97485cc532d6c56b2c5d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 688ef3856d0502d057c9543ee7763601156e6385
    Original-Change-Id: Ie376e394d084edd6c999fc9edde79f15a0264e7b
    Original-Signed-off-by: Furquan Shaikh <furquan at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/222664
    Original-Reviewed-by: Jimmy Zhang <jimmzhang at nvidia.com>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Tested-by: Furquan Shaikh <furquan at chromium.org>
    Original-Commit-Queue: Furquan Shaikh <furquan at chromium.org>
---
 payloads/libpayload/arch/arm64/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/arch/arm64/main.c b/payloads/libpayload/arch/arm64/main.c
index 4561e2e..aa02ff7 100644
--- a/payloads/libpayload/arch/arm64/main.c
+++ b/payloads/libpayload/arch/arm64/main.c
@@ -121,12 +121,12 @@ void start_main(void)
 	/* Gather system information. */
 	lib_get_sysinfo();
 
+	post_sysinfo_scan_mmu_setup();
+
 #ifndef CONFIG_LP_SKIP_CONSOLE_INIT
 	console_init();
 #endif
 
-	post_sysinfo_scan_mmu_setup();
-
 	printf("ARM64: Libpayload %s\n",__func__);
 	exception_init();
 



More information about the coreboot-gerrit mailing list