[coreboot-gerrit] Patch merged into coreboot/master: f72d328 libpayload/usb: wait a millisecond to work around device bugs

gerrit at coreboot.org gerrit at coreboot.org
Thu Mar 19 23:24:48 CET 2015


the following patch was just integrated into master:
commit f72d328d1285cfbaef4c0e13199d9e668414e06d
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Mon Nov 10 16:50:21 2014 +0100

    libpayload/usb: wait a millisecond to work around device bugs
    
    Some USB sticks seem to send a NAK at a place where they mustn't
    by spec, leading to a controller side error condition.
    
    To avoid it, wait a millisecond which is enough to get past the
    NAK condition. That delay only happens on device discovery so it
    won't affect boot time by more than 1ms per device.
    
    BUG=chromium:414959
    BRANCH=none
    TEST=depthcharge recognizes a Lexar 16GB USB stick after applying
    this change.
    
    Change-Id: I0e385702a5259b16fda0a253fc121d8f66e6705c
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 10bbfda8395af009e7f910cc503f50c2ad969ae8
    Original-Change-Id: I6dd5ca34e9f3767003ccb0ca9daaf16116f4a2df
    Original-Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/228791
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-by: Sheng-liang Song <ssl at chromium.org>
    Reviewed-on: http://review.coreboot.org/8735
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See http://review.coreboot.org/8735 for details.

-gerrit



More information about the coreboot-gerrit mailing list