[coreboot-gerrit] New patch to review for coreboot: 92d6a99 coreboot t132: Stop running AVP at the end of romstage

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Tue Mar 10 22:27:20 CET 2015


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8651

-gerrit

commit 92d6a9991e558ad92e19253a576e7acce9900852
Author: Furquan Shaikh <furquan at google.com>
Date:   Tue Jul 22 17:21:14 2014 -0700

    coreboot t132: Stop running AVP at the end of romstage
    
    Stop running AVP at the end of romstage until event conditions are met (JTAG,
    GIC_IRQ or LIC_IRQ).
    
    BUG=chrome-os-partner:30831
    BRANCH=None
    TEST=Compiles successfully and boots till last known good checkpoint.
    
    Original-Change-Id: Ia221f08b27ac0c60a66d588e351677144cc6a322
    Original-Signed-off-by: Furquan Shaikh <furquan at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/209424
    Original-Tested-by: Furquan Shaikh <furquan at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Commit-Queue: Furquan Shaikh <furquan at chromium.org>
    (cherry picked from commit df4e8b4c8a1002443a936bd0563fbc9e0710f489)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I59f7702bd50a1039b8723e9cb12b8d714e353d37
---
 src/soc/nvidia/tegra132/romstage.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/soc/nvidia/tegra132/romstage.c b/src/soc/nvidia/tegra132/romstage.c
index 4b1c843..812d147 100644
--- a/src/soc/nvidia/tegra132/romstage.c
+++ b/src/soc/nvidia/tegra132/romstage.c
@@ -29,6 +29,8 @@
 #include "sdram.h"
 #include "ccplex.h"
 
+#include <soc/clock.h>
+
 void romstage(void);
 void romstage(void)
 {
@@ -71,5 +73,5 @@ void romstage(void)
 
 	ccplex_cpu_start(entry);
 
-	while (1);
+	clock_halt_avp();
 }



More information about the coreboot-gerrit mailing list