[coreboot-gerrit] New patch to review for coreboot: 52beddd Makefile.inc: fix build timestamp logic for clean builds

Alexander Couzens (lynxis@fe80.eu) gerrit at coreboot.org
Fri Mar 6 03:43:10 CET 2015


Alexander Couzens (lynxis at fe80.eu) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8611

-gerrit

commit 52beddd3949f89d6c2b1459bfbbeb310fe8d0f24
Author: Alexander Couzens <lynxis at fe80.eu>
Date:   Fri Mar 6 01:18:15 2015 +0100

    Makefile.inc: fix build timestamp logic for clean builds
    
    When the build system detects a clean checkout it uses
    the git commit timestamp as `now` timestamp.
    The logic was wrong and it detect a clean checkout when it
    was dirty and vice versa.
    
    Change-Id: I20fc8648c84882fbc43ea7964aa4204941580f1e
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index eb8b601..d209872 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -278,7 +278,7 @@ $(obj)/build.h: .xcompile
 	printf "#ifndef __BUILD_H\n" >> $(obj)/build.ht
 	printf "#define __BUILD_H\n\n" >> $(obj)/build.ht
 	printf "#define COREBOOT_VERSION \"$(KERNELVERSION)\"\n" >> $(obj)/build.ht
-	if git update-index -q --refresh >/dev/null; ! git diff-index --quiet HEAD; then \
+	if git update-index -q --refresh >/dev/null; git diff-index --quiet HEAD; then \
 	   printf "/* `LANG= TZ=UTC git log --date=local --pretty=format:%cd -1` UTC */\n" >> $(obj)/build.ht; \
 	   printf "#define COREBOOT_VERSION_TIMESTAMP `LANG= git log --pretty=format:%ct -1`\n" >> $(obj)/build.ht; \
 	else \



More information about the coreboot-gerrit mailing list