[coreboot-gerrit] New patch to review for coreboot: 134b1e3 rush: PMIC: initial AS3722 PMIC writes for Rush

[Marc Jones (marc.jones@se-eng.com)]

Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8582

-gerrit

commit 134b1e30f5c1fbf88eaf192351da9e81e801c3e0
Author: Tom Warren <twarren at nvidia.com>
Date:   Tue Jul 1 17:08:27 2014 -0700

    rush: PMIC: initial AS3722 PMIC writes for Rush
    
    Still waiting on VDD_CPU value, etc. from board guys, but this is a start.
    
    BUG=None
    BRANCH=None
    TEST=Built and flashed rush, saw 'PMIC init done' string OK.
    
    Original-Change-Id: I6f8b16c4ebf1e9c159f8175d59262119ef0e498f
    Original-Signed-off-by: Tom Warren <twarren at nvidia.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/206412
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Commit-Queue: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit 96a9ff8f632c2b9bf3f81f5b8fc4f3b6784a02bc)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I9d3d7ff55f2d6ca88ebdcc8ad1d7de135f5136d2
---
 src/mainboard/google/rush/pmic.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/google/rush/pmic.c b/src/mainboard/google/rush/pmic.c
index c114066..7aa7dc9 100644
--- a/src/mainboard/google/rush/pmic.c
+++ b/src/mainboard/google/rush/pmic.c
@@ -92,19 +92,13 @@ void pmic_init(unsigned bus)
 	/* Restore PMIC POR defaults, in case kernel changed 'em */
 	pmic_slam_defaults(bus);
 
-	/* First set VDD_CPU to 1.2V, then enable the VDD_CPU regulator. */
-	if (board_id() == 0)
-		pmic_write_reg(bus, 0x00, 0x3c, 1);
-	else
-		pmic_write_reg(bus, 0x00, 0x50, 1);
+	/* SDO0: Set VDD_CPU to 1.2V. */
+	pmic_write_reg(bus, 0x00, 0x50, 1);
 
-	/* First set VDD_GPU to 1.0V, then enable the VDD_GPU regulator. */
+	/* SDO6: Set VDD_GPU to 1.0V. */
 	pmic_write_reg(bus, 0x06, 0x28, 1);
 
-	/*
-	 * First set +1.2V_GEN_AVDD to 1.2V, then enable the +1.2V_GEN_AVDD
-	 * regulator.
-	 */
+	/* LDO2: Set +1.2V_GEN_AVDD to 1.2V */
 	pmic_write_reg(bus, 0x12, 0x10, 1);
 
 	/*
@@ -113,4 +107,6 @@ void pmic_init(unsigned bus)
 	 */
 	pmic_write_reg(bus, 0x0c, 0x07, 0);
 	pmic_write_reg(bus, 0x20, 0x10, 1);
+
+	printk(BIOS_DEBUG, "PMIC init done\n");
 }