[coreboot-gerrit] New patch to review for coreboot: google/link: implement get_write_protect_state

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Jun 30 12:56:36 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10727

-gerrit

commit c9308f73fb39342b8985a1e5071711dd04308db3
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Tue Jun 30 12:49:50 2015 +0200

    google/link: implement get_write_protect_state
    
    Current vboot wants that function.
    
    Change-Id: I9d3a592c448cf2af10f76cae4518341cbc0a6f41
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/mainboard/google/link/chromeos.c | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/google/link/chromeos.c b/src/mainboard/google/link/chromeos.c
index a020b06..bc8a96a 100644
--- a/src/mainboard/google/link/chromeos.c
+++ b/src/mainboard/google/link/chromeos.c
@@ -33,22 +33,13 @@
 
 void fill_lb_gpios(struct lb_gpios *gpios)
 {
-	device_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
-	u16 gpio_base = pci_read_config32(dev, GPIOBASE) & 0xfffe;
-	//u16 gen_pmcon_1 = pci_read_config32(dev, GEN_PMCON_1);
-
-	if (!gpio_base)
-		return;
-
-	u32 gp_lvl2 = inl(gpio_base + 0x38);
-
 	gpios->size = sizeof(*gpios) + (GPIO_COUNT * sizeof(struct lb_gpio));
 	gpios->count = GPIO_COUNT;
 
 	/* Write Protect: GPIO57 = PCH_SPI_WP_D */
 	gpios->gpios[0].port = 57;
 	gpios->gpios[0].polarity = ACTIVE_HIGH;
-	gpios->gpios[0].value = (gp_lvl2 >> (57 - 32)) & 1;
+	gpios->gpios[0].value = get_write_protect_state();
 	strncpy((char *)gpios->gpios[0].name,"write protect",
 							GPIO_MAX_NAME_LENGTH);
 	/* Recovery: the "switch" comes from the EC */
@@ -84,6 +75,25 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 }
 #endif
 
+int get_write_protect_state(void)
+{
+	device_t dev;
+#ifdef __PRE_RAM__
+	dev = PCI_DEV(0, 0x1f, 0);
+#else
+	dev = dev_find_slot(0, PCI_DEVFN(0x1f, 0));
+#endif
+	u16 gpio_base = pci_read_config32(dev, GPIOBASE) & 0xfffe;
+	//u16 gen_pmcon_1 = pci_read_config32(dev, GEN_PMCON_1);
+
+	if (!gpio_base)
+		return -1;
+
+	u32 gp_lvl2 = inl(gpio_base + 0x38);
+
+	return (gp_lvl2 >> (57 - 32)) & 1;
+}
+
 int get_lid_switch(void)
 {
 	u8 ec_switches = inb(EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SWITCHES);



More information about the coreboot-gerrit mailing list