[coreboot-gerrit] New patch to review for coreboot: t210: Set UTMIP_PCOUNT_UPDN_DIV to 0

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Jun 29 17:10:24 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10695

-gerrit

commit 9bd11127607e5722270497d511c099370bda0dcb
Author: Stephen Barber <smbarber at chromium.org>
Date:   Tue Jun 16 13:44:13 2015 -0700

    t210: Set UTMIP_PCOUNT_UPDN_DIV to 0
    
    Improve USB device mode stability as per suggestion by Laurent.
    
    BUG=chrome-os-partner:40929
    BRANCH=smaug
    TEST=flash firmware and check that USB device mode is still functional.
    
    Change-Id: Id6dd7bb2e1632c512cfdf7d38a16de26a8f71471
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 4298741ef4440c8bd8dac4a9f9eaa55ba560cbfb
    Original-Change-Id: I07d6c46d215f2ccf2c76c580f59c4fa0d519eaa5
    Original-Signed-off-by: Stephen Barber <smbarber at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/278030
    Original-Reviewed-by: Benson Leung <bleung at chromium.org>
    Original-Tested-by: Benson Leung <bleung at chromium.org>
---
 src/soc/nvidia/tegra/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/nvidia/tegra/usb.c b/src/soc/nvidia/tegra/usb.c
index 5520c4f..e6de538 100644
--- a/src/soc/nvidia/tegra/usb.c
+++ b/src/soc/nvidia/tegra/usb.c
@@ -180,7 +180,7 @@ void usb_setup_utmip(void *usb_base)
 	write32(&usb->utmip.hsrx0,
 		0x2 << 30 |		/* (rst) Keep pattern on active */
 		  1 << 28 |		/* (rst) Realign inertia on pkt */
-		0x1 << 24 |		/* (rst) edges-1 to move sampling */
+		0x0 << 24 |		/* (rst) edges-1 to move sampling */
 		0x3 << 21 |		/* (rst) squelch delay on EoP */
 	       0x11 << 15 |		/* cycles until IDLE */
 	       0x10 << 10);		/* elastic input depth */



More information about the coreboot-gerrit mailing list