[coreboot-gerrit] New patch to review for coreboot: Add Kconfig flag to specify if there's a lid switch

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Jun 29 16:41:19 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10692

-gerrit

commit 5ce4f9843d09a474d9945786995f703d3eb74ea3
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Thu May 28 12:02:00 2015 +0200

    Add Kconfig flag to specify if there's a lid switch
    
    Not all devices have a lid switch, so we need to state this
    somehow. Since the alternative would be to extend get_lid_switch()'s
    semantics to become a tri-state (open, closed, N/A), do this
    through Kconfig.
    
    BRANCH=none
    BUG=chromium:446945
    TEST=none
    
    Change-Id: Icc50f72535f256051a59925a178fb27b2e8f7e55
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: d20a1d1a22d64546a5d8761b18ab29732ec0b848
    Original-Change-Id: Ie8ac401fbaad5b5a9f1dec2b67847c81f4cc94aa
    Original-Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/273850
    Original-Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Tested-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Queue: Patrick Georgi <pgeorgi at chromium.org>
---
 src/mainboard/google/auron/Kconfig     | 1 +
 src/mainboard/google/bolt/Kconfig      | 1 +
 src/mainboard/google/falco/Kconfig     | 1 +
 src/mainboard/google/link/Kconfig      | 1 +
 src/mainboard/google/peppy/Kconfig     | 1 +
 src/mainboard/google/rambi/Kconfig     | 1 +
 src/mainboard/google/samus/Kconfig     | 1 +
 src/mainboard/google/slippy/Kconfig    | 1 +
 src/vendorcode/google/chromeos/Kconfig | 6 ++++++
 9 files changed, 14 insertions(+)

diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig
index 740afe1..3a4cb7e 100644
--- a/src/mainboard/google/auron/Kconfig
+++ b/src/mainboard/google/auron/Kconfig
@@ -17,6 +17,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select CHROMEOS_RAMOOPS_DYNAMIC
 	select INTEL_INT15
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config VBOOT_RAMSTAGE_INDEX
 	hex
diff --git a/src/mainboard/google/bolt/Kconfig b/src/mainboard/google/bolt/Kconfig
index 17ec406..2e37e25 100644
--- a/src/mainboard/google/bolt/Kconfig
+++ b/src/mainboard/google/bolt/Kconfig
@@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select MAINBOARD_HAS_LPC_TPM
 	select INTEL_INT15
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/google/falco/Kconfig b/src/mainboard/google/falco/Kconfig
index 1234044..e029382 100644
--- a/src/mainboard/google/falco/Kconfig
+++ b/src/mainboard/google/falco/Kconfig
@@ -22,6 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select MAINBOARD_DO_NATIVE_VGA_INIT
 	select INTEL_INT15
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig
index 0f70925..fd3390a 100644
--- a/src/mainboard/google/link/Kconfig
+++ b/src/mainboard/google/link/Kconfig
@@ -16,6 +16,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SERIRQ_CONTINUOUS_MODE
 	select MAINBOARD_HAS_NATIVE_VGA_INIT
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/google/peppy/Kconfig b/src/mainboard/google/peppy/Kconfig
index 8c7d630..b507953 100644
--- a/src/mainboard/google/peppy/Kconfig
+++ b/src/mainboard/google/peppy/Kconfig
@@ -24,6 +24,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select INTEL_DDI
 	select INTEL_INT15
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig
index 1130d11..6fb19d4 100644
--- a/src/mainboard/google/rambi/Kconfig
+++ b/src/mainboard/google/rambi/Kconfig
@@ -15,6 +15,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select MAINBOARD_HAS_LPC_TPM
 	select ALWAYS_LOAD_OPROM
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/google/samus/Kconfig b/src/mainboard/google/samus/Kconfig
index 68d622d..0b4d74d 100644
--- a/src/mainboard/google/samus/Kconfig
+++ b/src/mainboard/google/samus/Kconfig
@@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select CHROMEOS_RAMOOPS_DYNAMIC
 	select INTEL_INT15
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index a2dd3d0..ba83683 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select INTEL_DDI
 	select INTEL_INT15
 	select CHROMEOS_VBNV_CMOS
+	select LID_SWITCH
 
 config MAINBOARD_DIR
 	string
diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig
index 51a04ed..2f04f24 100644
--- a/src/vendorcode/google/chromeos/Kconfig
+++ b/src/vendorcode/google/chromeos/Kconfig
@@ -149,6 +149,12 @@ config PHYSICAL_REC_SWITCH
 	help
 	  Whether this platform has a physical recovery switch
 
+config LID_SWITCH
+	bool "Lid switch is present"
+	default n
+	help
+	  Whether this platform has a lid switch
+
 config WIPEOUT_SUPPORTED
 	bool "User is able to request factory reset"
 	default n



More information about the coreboot-gerrit mailing list