[coreboot-gerrit] New patch to review for coreboot: Intel Firmware Descriptor Kconfig: remove USES_INTEL_ME

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Sat Jun 27 17:00:17 CEST 2015


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10678

-gerrit

commit 352aa8d94854a92be20f8350f0e6fbb3472c58af
Author: Martin Roth <gaumless at gmail.com>
Date:   Sat Jun 27 08:59:10 2015 -0600

    Intel Firmware Descriptor Kconfig: remove USES_INTEL_ME
    
    When I added the common IFD Kconfig and Makefile, My thinking was that
    I could use this symbol to differentiate between the ME and the TXE,
    and to exclude the ME questions from platforms that use the IFD, but
    don't use an ME, like Rangeley.  In practice this made things a lot
    more complicated and isn't worth it.
    
    Change-Id: I4428744e53c6bb7fc00a4fa4f0aa782c25fc9013
    Signed-off-by: Martin Roth <gaumless at gmail.com>
---
 src/southbridge/intel/common/firmware/Kconfig | 3 +--
 src/southbridge/intel/fsp_bd82x6x/Kconfig     | 1 -
 src/southbridge/intel/lynxpoint/Kconfig       | 1 -
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig
index 1f4d935..71434ac 100644
--- a/src/southbridge/intel/common/firmware/Kconfig
+++ b/src/southbridge/intel/common/firmware/Kconfig
@@ -39,7 +39,7 @@ config IFD_BIN_PATH
 
 config HAVE_ME_BIN
 	bool "Add Intel Management Engine firmware"
-	depends on USES_INTEL_ME && HAVE_IFD_BIN
+	depends on HAVE_IFD_BIN
 	help
 	  The Intel processor in the selected system requires a special firmware
 	  for an integrated controller called Management Engine (ME). The ME
@@ -90,5 +90,4 @@ config IFD_PLATFORM_SECTION
 	string
 	default ""
 
-
 endif #INTEL_FIRMWARE
diff --git a/src/southbridge/intel/fsp_bd82x6x/Kconfig b/src/southbridge/intel/fsp_bd82x6x/Kconfig
index fc2b6b3..85c6ee7 100644
--- a/src/southbridge/intel/fsp_bd82x6x/Kconfig
+++ b/src/southbridge/intel/fsp_bd82x6x/Kconfig
@@ -34,7 +34,6 @@ config SOUTH_BRIDGE_OPTIONS # dummy
 	select SPI_FLASH
 	select COMMON_FADT
 	select HAVE_INTEL_FIRMWARE
-	select USES_INTEL_ME
 
 config EHCI_BAR
 	hex
diff --git a/src/southbridge/intel/lynxpoint/Kconfig b/src/southbridge/intel/lynxpoint/Kconfig
index 2c71ab2..3c8ae11 100644
--- a/src/southbridge/intel/lynxpoint/Kconfig
+++ b/src/southbridge/intel/lynxpoint/Kconfig
@@ -33,7 +33,6 @@ config SOUTH_BRIDGE_OPTIONS # dummy
 	select PCIEXP_COMMON_CLOCK
 	select SPI_FLASH
 	select HAVE_INTEL_FIRMWARE
-	select USES_INTEL_ME
 
 config INTEL_LYNXPOINT_LP
 	bool



More information about the coreboot-gerrit mailing list