[coreboot-gerrit] New patch to review for coreboot: intel raminit: check correct registers in channel_test

Patrick Rudolph (siro@das-labor.org) gerrit at coreboot.org
Thu Jun 25 19:38:04 CEST 2015


Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10664

-gerrit

commit 1ec3f08b78c2abe3667433520676b27877cc5884
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Thu Jun 25 19:32:28 2015 +0200

    intel raminit: check correct registers in channel_test
    
    Found while doing code review. No actual problem was observed.
    
    Test system:
    * Intel IvyBridge
    * Gigabyte GA-B75M-D3H
    
    Verify byte-lane error count registers 0 to 7 instead of verifying byte-lane
    error count register 0 eight times in a row.
    
    Change-Id: Ife6ac6558b2f65ad947870cde5f15d90560ce6d9
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
 src/northbridge/intel/sandybridge/raminit_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c
index e567cce..8d1fecc 100644
--- a/src/northbridge/intel/sandybridge/raminit_native.c
+++ b/src/northbridge/intel/sandybridge/raminit_native.c
@@ -3392,7 +3392,7 @@ static void channel_test(ramctr_timing * ctrl)
 		write32(DEFAULT_MCHBAR + 0x4284 + (channel << 10), 0x000c0001);
 		wait_428c(channel);
 		FOR_ALL_LANES
-		    if (read32(DEFAULT_MCHBAR + 0x4340 + (channel << 10)))
+		    if (read32(DEFAULT_MCHBAR + 0x4340 + (channel << 10) + 4 * lane))
 			 die("Mini channel test failed (2)\n");
 	}
 }



More information about the coreboot-gerrit mailing list