[coreboot-gerrit] Patch set updated for coreboot: prog_loader: Play nice with gc-sections

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Jun 23 22:34:16 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10585

-gerrit

commit 6e82ae3ee42eac628302f798fe209be360305312
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Thu Jun 18 01:19:50 2015 -0700

    prog_loader: Play nice with gc-sections
    
    With an x86_64-elf toolchain, this code that is unused
    outside of ramstage, is causing undefined references.
    
    Help the compiler along a little bit by conditionally compiling
    the code in ramstage only.
    
    Change-Id: I75518149b53c24eda4b985b0fef856447e196dec
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/lib/prog_loaders.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c
index ec5eeb8..7c00aba 100644
--- a/src/lib/prog_loaders.c
+++ b/src/lib/prog_loaders.c
@@ -121,6 +121,8 @@ fail:
 	die("Ramstage was not loaded!\n");
 }
 
+#ifdef __RAMSTAGE__ // gc-sections should take care of this
+
 static struct prog global_payload =
 	PROG_INIT(ASSET_PAYLOAD, CONFIG_CBFS_PREFIX "/payload");
 
@@ -170,3 +172,5 @@ void payload_run(void)
 
 	prog_run(payload);
 }
+
+#endif



More information about the coreboot-gerrit mailing list