[coreboot-gerrit] New patch to review for coreboot: mainboard/msi/ms7135: remove bogus MADT IRQ override for timer

Jonathan A. Kollasch (jakllsch@kollasch.net) gerrit at coreboot.org
Tue Jun 23 16:45:38 CEST 2015


Jonathan A. Kollasch (jakllsch at kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10642

-gerrit

commit 1577953b59cf57dc827ada85732df10635786b8e
Author: Jonathan A. Kollasch <jakllsch at kollasch.net>
Date:   Tue Jun 23 09:43:46 2015 -0500

    mainboard/msi/ms7135: remove bogus MADT IRQ override for timer
    
    Stops Linux from complaining:
    
    [0.097286] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=0 pin2=0
    [0.100005] ..MP-BIOS bug: 8254 timer not connected to IO-APIC
    [0.100005] ...trying to set up timer (IRQ0) through the 8259A ...
    [0.100005] ..... (found apic 0 pin 0) ...
    [0.143507] ....... works.
    
    Change-Id: Ic09a6940f80e3da2c1f3c0ef04fb50a4096b7943
    Signed-off-by: Jonathan A. Kollasch <jakllsch at kollasch.net>
---
 src/mainboard/msi/ms7135/acpi_tables.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/mainboard/msi/ms7135/acpi_tables.c b/src/mainboard/msi/ms7135/acpi_tables.c
index f5ddec3..5581ada 100644
--- a/src/mainboard/msi/ms7135/acpi_tables.c
+++ b/src/mainboard/msi/ms7135/acpi_tables.c
@@ -47,9 +47,6 @@ unsigned long acpi_fill_madt(unsigned long current)
 	pci_write_config32(dev, 0x84, 0x0000007d);
 #endif
 
-	/* IRQ of timer */
-	current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)
-		current, 0, 0, 2, 0);
 	/* IRQ9 */
 	current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)
 		current, 0, 9, 9, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW);



More information about the coreboot-gerrit mailing list