[coreboot-gerrit] New patch to review for coreboot: buildgcc: Check for dependencies after printing banner

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Jun 16 22:40:50 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10566

-gerrit

commit ee1aa8fcdc2199f5cad654e0ccb08915b09162f1
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Tue Jun 16 22:38:23 2015 +0200

    buildgcc: Check for dependencies after printing banner
    
    For consistency in user output, move the check for all
    required utilities after printing the banner and parsing
    options.
    
    Change-Id: I5bf31368885c73e35f18b02d53d099f3f3871acc
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/crossgcc/buildgcc | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 0c6193d..c27d62c 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -174,21 +174,6 @@ searchtool()
 	false
 }
 
-TAR=$(searchtool tar) || exit $?
-PATCH=$(searchtool patch) || exit $?
-MAKE=$(searchtool make) || exit $?
-SHA1SUM=$(searchtool sha1sum)
-SHA512SUM=$(searchtool sha512sum)
-CHECKSUM=$SHA1SUM
-
-searchtool m4 > /dev/null
-searchtool bison > /dev/null
-searchtool flex flex > /dev/null
-searchtool g++ "Free Software Foundation" nofail > /dev/null || \
-searchtool clang "clang version" > /dev/null
-searchtool wget > /dev/null
-searchtool bzip2 "bzip2," > /dev/null
-
 download() {
 	package=$1
 	archive="$(eval echo \$$package"_ARCHIVE")"
@@ -577,6 +562,23 @@ case "$PACKAGE" in
 		;;
 esac
 
+# Find all the required tools:
+
+TAR=$(searchtool tar) || exit $?
+PATCH=$(searchtool patch) || exit $?
+MAKE=$(searchtool make) || exit $?
+SHA1SUM=$(searchtool sha1sum)
+SHA512SUM=$(searchtool sha512sum)
+CHECKSUM=$SHA1SUM
+
+searchtool m4 > /dev/null
+searchtool bison > /dev/null
+searchtool flex flex > /dev/null
+searchtool g++ "Free Software Foundation" nofail > /dev/null || \
+searchtool clang "clang version" > /dev/null
+searchtool wget > /dev/null
+searchtool bzip2 "bzip2," > /dev/null
+
 # This initial cleanup is useful when updating the toolchain script.
 
 if [ "$clean" = "1" ]; then



More information about the coreboot-gerrit mailing list