[coreboot-gerrit] New patch to review for coreboot: buildgcc: Define $CMAKE only if clang package is built

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Tue Jun 16 02:12:58 CEST 2015

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10556


commit 1c4fcf2bfed9855202e5eb92efd99416125256ab
Author: David Hendricks <dhendrix at chromium.org>
Date:   Mon Jun 15 17:03:22 2015 -0700

    buildgcc: Define $CMAKE only if clang package is built
    This moves the CMAKE definition down into the case statement
    for $PACKAGE so that it is only required when the user wants to
    build clang.
    With this approach, "./buildgcc -P clang" will error out with the
    "ERROR: Missing tool:" message if cmake is not installed.
    Change-Id: I1e5c1bd67ade8f93ba0390df7f234deb47b9b18a
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 util/crossgcc/buildgcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 7f440f7..552a6a2 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -165,7 +165,6 @@ searchtool()
 TAR=$(searchtool tar) || exit $?
 PATCH=$(searchtool patch) || exit $?
 MAKE=$(searchtool make) || exit $?
-CMAKE=$(searchtool cmake "cmake") || exit $?
 SHA1SUM=$(searchtool sha1sum)
 SHA512SUM=$(searchtool sha512sum)
@@ -554,6 +553,7 @@ case "$PACKAGE" in
+		CMAKE=$(searchtool cmake "cmake") || exit $?
 		NAME="IASL ACPI compiler"

More information about the coreboot-gerrit mailing list