[coreboot-gerrit] Patch set updated for coreboot: pcengines/apu1: Remove unused smbus.asl

Tobias Diedrich (ranma+coreboot@tdiedrich.de) gerrit at coreboot.org
Sun Jun 14 22:06:35 CEST 2015

Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10539


commit 3fe7183b95d815bdf8221fccf69c21d2517fcb1f
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Sat Jun 13 13:06:17 2015 +0200

    pcengines/apu1: Remove unused smbus.asl
    The smbus.asl operation regions prevent the Linux i2c driver (i2c_piix4)
    for this chipset from claiming the ioport ranges and thus it fails to
    The methods defined in smbus.asl are not used in the DSDT and also don't
    exist in the Vendorbios DSDT.
    In particular due to the following check in i2c-piix4.c will fail unless
    acpi_enforce_resources=no is explicitly set on the Linux kernel
      if (acpi_check_region(piix4_smba, SMBIOSIZE, piix4_driver.name))
              return -ENODEV;
    Depending on kernel options the only error message printed is
      ACPI Warning: SystemIO range 0x0000000000000B00-0x0000000000000B07
      conflicts with OpRegion 0x0000000000000B00-0x0000000000000B0B (\SMB0)
      ACPI: If an ACPI driver is available for this device, you should use
      it instead of the native driver
    However since it does not implement a standard interface there is no
    native ACPI driver for smbus.asl.
    Change-Id: Id8401e8b36f0e2412d490a92c20540a04d853125
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
 src/mainboard/pcengines/apu1/dsdt.asl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl
index 9358203..799f1fd 100644
--- a/src/mainboard/pcengines/apu1/dsdt.asl
+++ b/src/mainboard/pcengines/apu1/dsdt.asl
@@ -64,7 +64,6 @@ DefinitionBlock (
 	#include "acpi/sleep.asl"
 	#include "acpi/gpe.asl"
-	#include <southbridge/amd/cimx/sb800/acpi/smbus.asl>
 	#include "acpi/thermal.asl"
 /* End of ASL file */

More information about the coreboot-gerrit mailing list