[coreboot-gerrit] Patch set updated for coreboot: pcengines apu1: Don't include smbus.asl as it is unused

Tobias Diedrich (ranma+coreboot@tdiedrich.de) gerrit at coreboot.org
Sun Jun 14 20:03:20 CEST 2015

Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10539


commit 224d9dbb4ce5d8ace98db137479cf059c19955f2
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Sat Jun 13 13:06:17 2015 +0200

    pcengines apu1: Don't include smbus.asl as it is unused
    The smbus.asl operation regions prevent the Linux i2c driver for this
    chipset from claiming the ioport ranges and thus it fails to load.
    Since the methods provided by smbus.asl are not used in the APU1 DSDT,
    there is no need to include the asl in the first place.
    In particular on the PCEngines APU1 board no devices are connected to
    the SMBus on the board (by default, unless you solder some optional
    resistors), but there is an SMBus header for the user to connect custom
    devices to.
    Change-Id: Id8401e8b36f0e2412d490a92c20540a04d853125
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
 src/mainboard/pcengines/apu1/dsdt.asl | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl
index 9358203..00e679d 100644
--- a/src/mainboard/pcengines/apu1/dsdt.asl
+++ b/src/mainboard/pcengines/apu1/dsdt.asl
@@ -64,7 +64,11 @@ DefinitionBlock (
 	#include "acpi/sleep.asl"
 	#include "acpi/gpe.asl"
-	#include <southbridge/amd/cimx/sb800/acpi/smbus.asl>
+	/* smbus.asl prevents the Linux smbus driver from loading and this DSDT
+	 * doesn't use any smbus methods */
+	/* #include <southbridge/amd/cimx/sb800/acpi/smbus.asl> */
 	#include "acpi/thermal.asl"
 /* End of ASL file */

More information about the coreboot-gerrit mailing list